From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23755 invoked by alias); 4 Aug 2009 18:20:46 -0000 Received: (qmail 23745 invoked by uid 22791); 4 Aug 2009 18:20:45 -0000 X-SWARE-Spam-Status: No, hits=0.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_JMF_BL,RCVD_IN_SORBS_WEB,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout5.012.net.il (HELO mtaout5.012.net.il) (84.95.2.13) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 04 Aug 2009 18:20:38 +0000 Received: from conversion-daemon.i_mtaout5.012.net.il by i_mtaout5.012.net.il (HyperSendmail v2004.12) id <0KNV00A006U32J00@i_mtaout5.012.net.il> for gdb-patches@sourceware.org; Tue, 04 Aug 2009 21:20:34 +0300 (IDT) Received: from HOME-C4E4A596F7 ([77.127.149.138]) by i_mtaout5.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0KNV0072O6YAN0Z0@i_mtaout5.012.net.il>; Tue, 04 Aug 2009 21:20:34 +0300 (IDT) Date: Tue, 04 Aug 2009 18:20:00 -0000 From: Eli Zaretskii Subject: Re: Ping: CRC32 documentation patch In-reply-to: <1249407367.3284.80.camel@thomas> To: jeremy.bennett@embecosm.com Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83ocqvo2z1.fsf@gnu.org> References: <200907242331.n6ONVqSl003646@greed.delorie.com> <83fxcl4491.fsf@gnu.org> <4A6B5BDD.80602@vmware.com> <1249407367.3284.80.camel@thomas> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-08/txt/msg00059.txt.bz2 > From: Jeremy Bennett > Date: Tue, 04 Aug 2009 18:36:07 +0100 > > This patch clarifies how CRC is calculated in the GDB manual. I think it > probably got lost in the rest of the discussion of CRC. Yes, sorry. > Any comments? Some. > +The CRC used in @code{.gnu_debuglink} is the CRC-32 defined in > +IEEE 802.3 using the polynomial @math{x^{32} + x^{26} + x^{23} + x^{22} > ++ x^{16} + x^{12} +x^{11} + x^{10} + x^8 + x^7 + x^5 + x^4 + x^2 + x + > +1}. The function is computed byte at a time, taking the least Would the polynomial look better, both in print and in on-line versions of the manual, if you put it into a @quotation or a @display, and break it into separate lines manually? I fear that leaving the line-breaking job to makeinfo or even TeX could produce ugly results beyond our control. > +significant bit of each byte first. The initial pattern > +@code{0xffffffff} is used, to ensure leading zeros affect the CRC and > +the final result is inverted to ensure trailing zeros also affect the > +CRC. Please leave two spaces between sentences, not one (here and elsewhere in the patch). > +For a complete explanation the code for the function used in > +@code{.gnu_debuglink} is given here. I suggest to reword like this (avoiding passive tense): To complete the description, we show below the code of the function which produces the CRC used in @code{.gnu_debuglink}. Okay with these corrections. Thanks.