From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29679 invoked by alias); 5 Sep 2009 07:24:57 -0000 Received: (qmail 29662 invoked by uid 22791); 5 Sep 2009 07:24:52 -0000 X-SWARE-Spam-Status: No, hits=-1.6 required=5.0 tests=AWL,BAYES_00,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout5.012.net.il (HELO mtaout5.012.net.il) (84.95.2.13) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 05 Sep 2009 07:24:47 +0000 Received: from conversion-daemon.i_mtaout5.012.net.il by i_mtaout5.012.net.il (HyperSendmail v2004.12) id <0KPH00200LPW4G00@i_mtaout5.012.net.il> for gdb-patches@sourceware.org; Sat, 05 Sep 2009 10:23:26 +0300 (IDT) Received: from HOME-C4E4A596F7 ([84.228.50.163]) by i_mtaout5.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0KPH00ILZLV18GE0@i_mtaout5.012.net.il>; Sat, 05 Sep 2009 10:23:26 +0300 (IDT) Date: Sat, 05 Sep 2009 07:24:00 -0000 From: Eli Zaretskii Subject: Re: [RFC 1/3] catch syscall -- try 6 -- Source-code modifications In-reply-to: <200909041600.47670.sergiodj@linux.vnet.ibm.com> To: =?iso-8859-1?q?S=E9rgio_Durigan_J=FAnior?= Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83ocpp501z.fsf@gnu.org> References: <200909041600.47670.sergiodj@linux.vnet.ibm.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00114.txt.bz2 > +/* Syscall catch. NEEDED is nonzero if any syscall catch (of any > + kind) is requested. ANY_COUNT is nonzero if a generic > + (filter-less) syscall catch is being requested. TABLE is an array > + of ints, indexed by syscall number. An element in this array is > + nonzero if that syscall should be caught. TABLE_SIZE is the number > + of elements in TABLE. */ > + > +#define target_set_syscall_catchpoint(pid, needed, any_count, table_size, table) \ > + (*current_target.to_set_syscall_catchpoint) (pid, needed, any_count, \ > + table_size, table) > + Could you perhaps expand the comment a bit more? For example, what should the target do if NEEDED is zero? Also, I understand that ANY_COUNT nonzero means TABLE should be ignored, is that right? IOW, imagine that someone is to implement this method, and try to give any information necessary to write the code. Thanks.