From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 544 invoked by alias); 23 Nov 2010 19:10:11 -0000 Received: (qmail 357 invoked by uid 22791); 23 Nov 2010 19:10:09 -0000 X-SWARE-Spam-Status: No, hits=-0.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout21.012.net.il (HELO mtaout21.012.net.il) (80.179.55.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 23 Nov 2010 19:09:54 +0000 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0LCC00200QEH7900@a-mtaout21.012.net.il> for gdb-patches@sourceware.org; Tue, 23 Nov 2010 21:09:51 +0200 (IST) Received: from HOME-C4E4A596F7 ([84.229.9.106]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LCC00298QKC0350@a-mtaout21.012.net.il>; Tue, 23 Nov 2010 21:09:50 +0200 (IST) Date: Tue, 23 Nov 2010 19:10:00 -0000 From: Eli Zaretskii Subject: Re: [patch 1/2] build id In-reply-to: <4CEBEB78.1020809@redhat.com> To: sami wagiaalla Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83oc9f97nr.fsf@gnu.org> References: <4CEBEB78.1020809@redhat.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-11/txt/msg00366.txt.bz2 > Date: Tue, 23 Nov 2010 11:27:36 -0500 > From: sami wagiaalla > > This patch comes from the Fedora rpm and supports the use of build id > for locating and loading core file executables, and printing information > about missing debug info files. Thanks. > + add_setshow_boolean_cmd ("build-id-core-loads", class_files, > + &build_id_core_loads, _("\ > +Set whether CORE-FILE loads the build-id associated files automatically."), _("\ > +Show whether CORE-FILE loads the build-id associated files automatically.."), If by CORE-FILE you mean the command "core-file", then I suggest to use \"core-file\" here. > +You can also adjust the current verbosity of the @dfn{build id} locating. The @dfn markup should be used only once, when the terminology is first used and explained. Thereafter, you should not use @dfn, but rather regular text. > +@kindex set build-id-verbose > +@item set build-id-verbose 0 > +No additional messages are printed. It is better to say "Verbose messages are off." > +@item set build-id-verbose 1 > +Missing separate debug filenames are printed. It's better to avoid passive tense: Print names of separate debug files that couldn't be found. > +@item set build-id-verbose 2 > +Missing separate debug filenames are printed and also all the parsing of the > +binaries to find their @dfn{build id} content is printed. Print missing separate debug files, and also be verbose about parsing of the binaries to find their build IDs. > +#define BUILD_ID_VERBOSE_NONE 0 > +#define BUILD_ID_VERBOSE_FILENAMES 1 > +#define BUILD_ID_VERBOSE_BINARY_PARSE 2 Isn't it better to use an enum? > + /* FIXME: bad alignment assumption. */ Should this FIXME be fixed before committing? > + gdb_byte *data = (void *) descdata; Why do you need this cast?