From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26570 invoked by alias); 23 Apr 2011 11:09:27 -0000 Received: (qmail 26562 invoked by uid 22791); 23 Apr 2011 11:09:26 -0000 X-SWARE-Spam-Status: No, hits=-0.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 23 Apr 2011 11:09:11 +0000 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0LK300L00Q7SL200@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Sat, 23 Apr 2011 14:09:02 +0300 (IDT) Received: from HOME-C4E4A596F7 ([77.127.55.52]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LK300LGLQYZ2S70@a-mtaout22.012.net.il>; Sat, 23 Apr 2011 14:09:02 +0300 (IDT) Date: Sat, 23 Apr 2011 11:09:00 -0000 From: Eli Zaretskii Subject: Re: [patch] [gdbserver] Fix multi-GB error log files [doc review] In-reply-to: <20110423080023.GA19201@host1.jankratochvil.net> To: Jan Kratochvil Cc: pedro@codesourcery.com, gdb-patches@sourceware.org, dan@codesourcery.com Reply-to: Eli Zaretskii Message-id: <83oc3xb4xf.fsf@gnu.org> References: <20110306115536.GA31532@host1.jankratochvil.net> <201103151941.16708.pedro@codesourcery.com> <20110316093228.GA27281@host1.jankratochvil.net> <201103161013.41848.pedro@codesourcery.com> <20110417140428.GA2085@host1.jankratochvil.net> <83y638on5c.fsf@gnu.org> <20110422214145.GA11969@host1.jankratochvil.net> <83vcy5biid.fsf@gnu.org> <20110423080023.GA19201@host1.jankratochvil.net> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-04/txt/msg00424.txt.bz2 > Date: Sat, 23 Apr 2011 10:00:23 +0200 > From: Jan Kratochvil > Cc: pedro@codesourcery.com, gdb-patches@sourceware.org, dan@codesourcery.com > > On Sat, 23 Apr 2011 08:15:38 +0200, Eli Zaretskii wrote: > > GDBserver now keeps its listening port open, unless you start > > GDBserver with the --once option. Keeping the listening port open > > allows subsequent reconnections from another GDB session. > > BTW personally I read it as if GDBserver did not support reconnections before > and that reconnections are a new feature (which they are not). Ah, in that case, that's my mistake: I indeed thought the possibility to reconnect was new. So I guess the right wording of this entry would be The new option --once causes GDBserver to stop listening for connections once the first connection is made. The listening port used by GDBserver will become available after that. > > > + Option @option{--multi} is not directly related > > > +to @kbd{target extended-remote} (therefore @kbd{target remote} is also > > > +compatible) and vice versa. > > > > It's not clear to me how this sentence is related to the surrounding > > text. What potential problem did you try to prevent by that? > > Yes, I was considering to post it as a separate patch but (a) it would be > a hassle for one sentence and (b) it is all related together anyway. > > --multi, remote/extended-remote and --once all together affect when gdbserver > will / will not terminate. Normally AFAIK one uses either: > --multi with extended-remote > or > (default) with remote > so I was curious if one can mix the two modes. And to my surprise gdbserver > behavior in which cases it terminates depends on how GDB connects to it > (remote/extended-remote) instead of the gdbserver arguments (--multi). > This is why this question seemed to me logical in the context of explaining > all the GDB termination rules which needed to be explained together with the > port allocation rules. How about this modified text, then? Note that the conditions under which @code{gdbserver} terminates depend on how @value{GDBN} connects to it (@kbd{target remote} or @kbd{target extended-remote}). The @option{--multi} option to @code{gdbserver} has no influence on that. > > > +terminated in @kbd{target remote} mode. On the other hand for @kbd{target > > ^ > > Missing comma there. > > You wrote it as "On the other, hand for " but I have used "On the other hand, > for ", either a typo or a font layout problem on your side. It's my mistake, sorry. The comma should be after "hand", of course. > Added @cindex for --once. > > Used all your other suggestions, I am not aware much of the commas. > > I will check it in if no futher comments appear. Apart of the above two issues, the new text is fine with me. Thanks.