Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Completion of add-inferior
Date: Fri, 11 May 2012 20:55:00 -0000	[thread overview]
Message-ID: <83obpuxwr4.fsf@gnu.org> (raw)
In-Reply-To: <87txzmxye6.fsf@fleche.redhat.com>

> From: Tom Tromey <tromey@redhat.com>
> Cc: gdb-patches@sourceware.org
> Date: Fri, 11 May 2012 14:20:49 -0600
> 
> >>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:
> 
> Eli> 2012-05-11  Eli Zaretskii  <eliz@gnu.org>
> Eli> 	* inferior.c: Include completer.h
> Eli> 	(initialize_inferiors): Set completer of add-inferior to
> Eli> 	filename_completer.
> 
> It isn't perhaps ideal, but it is better than the status quo, so ok.

Thanks for the review.

In what way is it not ideal?  Did you want to complete on file names
only when -exec was used?  I thought about that, but then I realized
that any other way of invoking that command cannot benefit from any
completion at all.

Or did you have something else in mind?


  reply	other threads:[~2012-05-11 20:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-11 17:51 Eli Zaretskii
2012-05-11 20:21 ` Tom Tromey
2012-05-11 20:55   ` Eli Zaretskii [this message]
2012-05-11 20:58     ` Tom Tromey
2012-05-12  6:36   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83obpuxwr4.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox