From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19275 invoked by alias); 6 Aug 2012 16:19:11 -0000 Received: (qmail 19257 invoked by uid 22791); 6 Aug 2012 16:19:10 -0000 X-SWARE-Spam-Status: No, hits=-4.2 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout21.012.net.il (HELO mtaout21.012.net.il) (80.179.55.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 06 Aug 2012 16:18:54 +0000 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0M8C00K00DA68A00@a-mtaout21.012.net.il> for gdb-patches@sourceware.org; Mon, 06 Aug 2012 19:18:51 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0M8C00JY0DBFXDB0@a-mtaout21.012.net.il>; Mon, 06 Aug 2012 19:18:51 +0300 (IDT) Date: Mon, 06 Aug 2012 16:19:00 -0000 From: Eli Zaretskii Subject: Re: [obv] add kindex for set remote hardware-{watchpoint,breakpoint}-limit In-reply-to: <1981863.INEZdKZT0P@qiyao.dyndns.org> To: Yao Qi Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83obmo9eoi.fsf@gnu.org> References: <1344005996-9097-1-git-send-email-yao@codesourcery.com> <83ipd0au60.fsf@gnu.org> <1981863.INEZdKZT0P@qiyao.dyndns.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00184.txt.bz2 > From: Yao Qi > Date: Mon, 6 Aug 2012 23:29:13 +0800 > > On Friday, August 03, 2012 06:09:59 PM Eli Zaretskii wrote: > > Sorry, but it isn't obvious. You will see that this whole node has > > only one kindex entry: "@kindex set remote". There are other "set > > remote SOMETHING" commands described there, but none of them has a > > @kindex entry. > > > > The reason for that is simple: it is not useful to have several index > > entries that all begin with the same string and all point to the same > > page. > > The reason I post this patch is that I was unable to find 'set remote > hardware-breakpoint-limit' in 'Command and Variable Index'. But "set remote" is there, isn't it? When you cannot find a subcommand in the index, you should go for its parent command. > I thought we need > kindex for *every* command in documentation, and that is why we need "index". > Otherwise, the criteria of using kindex is not clear, IMO. The criteria for kindex is to index every command, but not necessarily every subcommand. So "set remote" is indexed. Another example of a command with lots of subcommands which are not indexed is "set print" (although I see that a couple of subcommands sneaked in). Again, having lots of index entries with identical beginning pointing to the same page is not useful. Think how this looks in the printed manual, for example. OK?