From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-98862-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 4141 invoked by alias); 27 Feb 2013 20:24:02 -0000
Received: (qmail 4089 invoked by uid 22791); 27 Feb 2013 20:23:59 -0000
X-SWARE-Spam-Status: No, hits=-4.5 required=5.0	tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 27 Feb 2013 20:23:49 +0000
Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MIW00J00B84H500@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Wed, 27 Feb 2013 22:23:21 +0200 (IST)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MIW00J1BBAX0QE0@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Wed, 27 Feb 2013 22:23:21 +0200 (IST)
Date: Wed, 27 Feb 2013 21:05:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [patch] gdbserver/win32-low.c: Fix printf-like formatting (was Re: [patch]: Replace stryoul call to fetch address)
In-reply-to: <20130227195013.GC30418@calimero.vinschen.de>
To: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83obf5wlon.fsf@gnu.org>
References: <20130227164419.GA16975@calimero.vinschen.de> <512E404E.6070504@redhat.com> <20130227183805.GA30418@calimero.vinschen.de> <512E5B26.7050104@redhat.com> <20130227194235.GB30418@calimero.vinschen.de> <20130227195013.GC30418@calimero.vinschen.de>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2013-02/txt/msg00712.txt.bz2

> Date: Wed, 27 Feb 2013 20:50:13 +0100
> From: Corinna Vinschen <vinschen@redhat.com>
> 
> @@ -1452,7 +1452,7 @@ get_child_debug_event (struct target_wai
>      {
>      case CREATE_THREAD_DEBUG_EVENT:
>        OUTMSG2 (("gdbserver: kernel event CREATE_THREAD_DEBUG_EVENT "
> -		"for pid=%d tid=%x)\n",
> +		"for pid=%u tid=%x)\n",
>  		(unsigned) current_event.dwProcessId,
>  		(unsigned) current_event.dwThreadId));
>  
> @@ -1465,7 +1465,7 @@ get_child_debug_event (struct target_wai
>  
>      case EXIT_THREAD_DEBUG_EVENT:
>        OUTMSG2 (("gdbserver: kernel event EXIT_THREAD_DEBUG_EVENT "
> -		"for pid=%d tid=%x\n",
> +		"for pid=%u tid=%x\n",
>  		(unsigned) current_event.dwProcessId,
>  		(unsigned) current_event.dwThreadId));
>        child_delete_thread (current_event.dwProcessId,

I don't understand the need for any of these changes.  DWORD is
already an unsigned integer type:

  typedef unsigned long DWORD;

(this is from windef.h).  So why do we need to cast it to 'unsigned'??
What "type related warnings" did you see?