[PATCH 26/28] fix refcount bug in typy_fields

Tom Tromey
2013-04-19T14:43:30Z

The checker found a bug in typy_fields -- we leaked a reference in one
path.

* python/py-type.c (typy_fields): Unconditionally decref 'r'.
---
gdb/python/py-type.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/gdb/python/py-type.c b/gdb/python/py-type.c
index 63629fe..337e307 100644
--- a/gdb/python/py-type.c
+++ b/gdb/python/py-type.c
@@ -379,10 +379,7 @@ typy_fields (PyObject *self, PyObject *args)
return NULL;

rl = Py_BuildValue ("[O]", r);
- if (rl == NULL)
- {
- Py_DECREF (r);
- }
+ Py_DECREF (r);

return rl;
}
--
1.8.1.4