From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-102428-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 8789 invoked by alias); 13 Jun 2013 13:09:02 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 8778 invoked by uid 89); 13 Jun 2013 13:09:02 -0000
X-Spam-SWARE-Status: No, score=-4.2 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,SPF_SOFTFAIL autolearn=no version=3.3.1
Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 13 Jun 2013 13:09:01 +0000
Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MOC007001UW0500@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Thu, 13 Jun 2013 16:08:58 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MOC006XH1UWZQ00@a-mtaout22.012.net.il>; Thu, 13 Jun 2013 16:08:56 +0300 (IDT)
Date: Thu, 13 Jun 2013 14:27:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH 5/6] New MI command -trace-frame-collected
In-reply-to: <1371086914-8398-6-git-send-email-yao@codesourcery.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83obbaw425.fsf@gnu.org>
References: <1370610493-26468-1-git-send-email-yao@codesourcery.com> <1371086914-8398-1-git-send-email-yao@codesourcery.com> <1371086914-8398-6-git-send-email-yao@codesourcery.com>
X-SW-Source: 2013-06/txt/msg00312.txt.bz2

> From: Yao Qi <yao@codesourcery.com>
> Date: Thu, 13 Jun 2013 09:28:33 +0800
> 
> This patch adds the new MI command -trace-frame-collected, which can
> dump explicitly collected variables, computed expressions, tvars,
> memory and registers.  See details in the doc about MI command
> options.

Thanks.

> diff --git a/gdb/NEWS b/gdb/NEWS
> index 2c66db7..d480f45 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -80,6 +80,10 @@ show range-stepping
>       "--skip-unavailable" option.  When used, only the available registers
>       are displayed.
>  
> +  ** The new command -trace-frame-collected dumps explicitly collected
> +     variables, computed expressions, tvars, memory and registers in a
> +     traceframe.
> +

This is OK.

> +This command returns the set of explicitly wholly collected objects,

What is meant by "explicitly wholly collected objects"?  That phrase
got me confused, especially the "wholly" part.

> +For instance, if the actions were @code{myVar, myArray[myIndex]
> +myObj.field, myPtr->field, myCount + 2, *(int*)0xaf02bef0@@40}, the

It is better to put the code part in @smallexample.

> +@item computed-expressions
> +The set of computed expressions that have been collected at the
> +current trace frame.  The @code{--comp-print-values} option affects
> +this set, as the @code{--var-print-values} option affects the
             ^^
"like", not "as".  And you don't need the comma before that.

OK with the above changes, and assuming we resolve the "wholly" issue.