From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-113330-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 21410 invoked by alias); 9 Jun 2014 19:26:05 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 21154 invoked by uid 89); 9 Jun 2014 19:26:02 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,SPF_SOFTFAIL autolearn=no version=3.3.2
X-HELO: mtaout27.012.net.il
Received: from mtaout27.012.net.il (HELO mtaout27.012.net.il) (80.179.55.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 09 Jun 2014 19:26:01 +0000
Received: from conversion-daemon.mtaout27.012.net.il by mtaout27.012.net.il (HyperSendmail v2007.08) id <0N6X00C001NOV900@mtaout27.012.net.il> for gdb-patches@sourceware.org; Mon, 09 Jun 2014 22:22:55 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout27.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N6X007Y41U7AX60@mtaout27.012.net.il>; Mon, 09 Jun 2014 22:22:55 +0300 (IDT)
Date: Mon, 09 Jun 2014 19:26:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH] Add Frame.read_register to Python API
In-reply-to: <CAHQ51u4gJRVFXNnUykc6EmCCFGd4O3+LJmpjFGMZ9AeQSvQCuQ@mail.gmail.com>
To: Alexander Smundak <asmundak@google.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83oay128ca.fsf@gnu.org>
References: <CAHQ51u4gJRVFXNnUykc6EmCCFGd4O3+LJmpjFGMZ9AeQSvQCuQ@mail.gmail.com>
X-IsSubscribed: yes
X-SW-Source: 2014-06/txt/msg00402.txt.bz2

> Date: Mon, 9 Jun 2014 12:15:26 -0700
> From: Alexander Smundak <asmundak@google.com>
> 
> 2014-06-09  Sasha Smundak  <asmundak@google.com>
> 
> * python.texi (Writing a Frame Filter): Fix example code.
> (Frames in Python): Add read_register description.
> (Frames in Python): Fix reference in find_sal description.

When 2 changes are in the same node, write them one after the other,
and have only one "(Node Name)" thing.

> +* Python Scripting
> +  Access frame registers

This is an incomplete sentence.  I guess you meant something like

  You can now access frame registers from Python scripts.

> +Return the value of @var{register} in this frame. The @var{register}
> +argument must be a string (e.g., 'rsp' or 'r1'), or a register number.
                                    ^^^^^^^^^^^^^
These should be in @code instead of quotes.

> +Returns @code{Gdb.Value} object.
          ^
"a" missing here.

The documentation parts are OK with these fixed.