From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 48382 invoked by alias); 19 Apr 2016 02:33:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 48370 invoked by uid 89); 19 Apr 2016 02:33:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=HX-Received-From:134, HX-Received-From:4830, HX-Received-From:2001, HX-HELO:eggs.gnu.org X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 19 Apr 2016 02:33:40 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1asLTq-00011h-AV for gdb-patches@sourceware.org; Mon, 18 Apr 2016 22:33:38 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35464) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1asLTq-00011d-7X; Mon, 18 Apr 2016 22:33:34 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2164 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1asLTp-0004hy-KR; Mon, 18 Apr 2016 22:33:34 -0400 Date: Tue, 19 Apr 2016 02:33:00 -0000 Message-Id: <83oa968gzx.fsf@gnu.org> From: Eli Zaretskii To: Doug Evans CC: gdb-patches@sourceware.org In-reply-to: (message from Doug Evans on Mon, 18 Apr 2016 13:01:37 -0700) Subject: Re: [PATCH 2/3] deprecate "skip enable/etc.", doc string cleanup Reply-to: Eli Zaretskii References: <047d7bdc05e2ada5ef0530c446d1@google.com> <83zisq923i.fsf@gnu.org> <83potm8zj2.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2016-04/txt/msg00426.txt.bz2 > From: Doug Evans > Date: Mon, 18 Apr 2016 13:01:37 -0700 > Cc: gdb-patches > > On Mon, Apr 18, 2016 at 12:53 PM, Eli Zaretskii wrote: > >> From: Doug Evans > >> Date: Mon, 18 Apr 2016 12:42:04 -0700 > >> Cc: gdb-patches > >> > >> I certainly don't want to replicate all that text again > >> and again (hence the macros). > > > > I understand, but put yourself in the position of someone who needs to > > review a patch, and sees something like this: > > > > +Display the status of skips.\n" > > +EDDI_USAGE_DOC_STRING_WITH_ALL ("skip", "info skip", "displayed"))); > > > > How does that someone know if the resulting text is good English and > > will produce a clear help text, or needs to be fixed in some way? > > I'm open to suggestions. > > I really hope the solution is to not expand all those macro > invocations in place. If I'm the only one who is bothered by such macro-izing of doc strings, then just ignore me.