From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 60160 invoked by alias); 18 Jul 2016 15:11:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 60147 invoked by uid 89); 18 Jul 2016 15:11:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=HX-HELO:eggs.gnu.org, Hx-spam-relays-external:208.118.235.92, H*RU:208.118.235.92 X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 18 Jul 2016 15:11:02 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bPAC9-0007nG-Nl for gdb-patches@sourceware.org; Mon, 18 Jul 2016 11:11:00 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54340) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPAC9-0007n6-Kf; Mon, 18 Jul 2016 11:10:57 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2707 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bPAC7-0003Xp-TO; Mon, 18 Jul 2016 11:10:56 -0400 Date: Mon, 18 Jul 2016 15:11:00 -0000 Message-Id: <83oa5v0yo1.fsf@gnu.org> From: Eli Zaretskii To: David Taylor CC: gdb-patches@sourceware.org In-reply-to: <24519.1468851836@usendtaylorx2l> (message from David Taylor on Mon, 18 Jul 2016 10:23:56 -0400) Subject: Re: [PATCH] Add '-at location' support to 'macro expand', 'macro expand-once', 'info macro', 'ptype', and 'whatis' commands. Reply-to: Eli Zaretskii References: <24519.1468851836@usendtaylorx2l> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2016-07/txt/msg00193.txt.bz2 > From: David Taylor > Date: Mon, 18 Jul 2016 10:23:56 -0400 > > Add '-at location' support to 'macro expand', 'macro expand-once', 'info > macro', 'ptype', and 'whatis' commands. Thanks. > +it can be any string of tokens. If the optional @var{location} is > +specified, it is used to determine which macro definitions are in > +scope; otherwise, as before, it uses the source and line asociated with > +the current program counter. Please lose the "as before" part, it is not appropriate for the manual, since we always describe the current state of events. Also, there's a type in "asociated". > +can be any string of tokens. If the optional @var{location} is > +specified, it is used to determine which macro definitions are in > +scope; otherwise, as before, it uses the source and line asociated with > +the current program counter. Likewise. > +definition was established. The optional double dash is to signify the > +end of argument processing and the beginning of @var{macro} for non > +C-like macros where the macro may begin with a hyphen. If the optional > +@var{location} is specified, it is used to determine which definition, > +if any, of the macro is in scope; otherwise, as before, it uses the > +source and line asociated with the current program counter. Likewise. The documentation parts are approved with these fixed. > add_cmd ("expand", no_class, macro_expand_command, _("\ > Fully expand any C/C++ preprocessor macro invocations in EXPRESSION.\n\ > -Show the expanded expression."), > +Show the expanded expression.\n\ > +Usage: macro expand [-at LCOATION,] [--] EXPR\n\ ^^^^^^^^ Typo. > +Options:\n\ > + -at Use LOCATION rather than the current PC for selecting macros.\n\ "Selecting" sounds not very accurate. Wouldn't "expanding" be better?