From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 95833 invoked by alias); 9 Feb 2017 20:47:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 95818 invoked by uid 89); 9 Feb 2017 20:47:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=simon.marchi@ericsson.com, simonmarchiericssoncom, H*MI:sk:0322ea0, Hx-languages-length:1010 X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 09 Feb 2017 20:46:51 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cbvc6-0006kZ-Gh for gdb-patches@sourceware.org; Thu, 09 Feb 2017 15:46:49 -0500 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50453) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cbvc6-0006kV-EG; Thu, 09 Feb 2017 15:46:46 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4161 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cbvc5-0007lE-Iy; Thu, 09 Feb 2017 15:46:46 -0500 Date: Thu, 09 Feb 2017 20:47:00 -0000 Message-Id: <83o9yb3xdx.fsf@gnu.org> From: Eli Zaretskii To: Pedro Alves CC: simon.marchi@polymtl.ca, simon.marchi@ericsson.com, gdb-patches@sourceware.org In-reply-to: <8688edde-759a-7f84-482d-9823a8f546b3@redhat.com> (message from Pedro Alves on Thu, 9 Feb 2017 17:53:16 +0000) Subject: Re: [PATCH] Fix usage of inferior_ptid in two thread_alive implementations Reply-to: Eli Zaretskii References: <20170207212450.2232-1-simon.marchi@ericsson.com> <0322ea0c-ce96-8b7c-5d2d-0efa87ab71ed@redhat.com> <8688edde-759a-7f84-482d-9823a8f546b3@redhat.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2017-02/txt/msg00235.txt.bz2 > Cc: Simon Marchi , gdb-patches@sourceware.org > From: Pedro Alves > Date: Thu, 9 Feb 2017 17:53:16 +0000 > > On 02/09/2017 04:46 PM, Simon Marchi wrote: > > On 2017-02-08 07:40, Pedro Alves wrote: > >> On 02/07/2017 09:24 PM, Simon Marchi wrote: > >>> While inspecting some target code, I noticed that in these two > >>> implementations of thread_alive, inferior_ptid is referenced directly > >>> instead of using the ptid passed as parameters. I guess that it is > >>> wrong, although I can't really test it in both cases. > >> > >> I can't test either, but it looks right to me. > > > > Soooo.. is this an approval :) ? > > OK by the end of the week to give a chance of area > maintainers or interested folks to comment. E.g., Eli > is the go32-nat.c maintainer and I don't mean to overstep, > though that bit does look obvious to me. Is that function even called in the go32 port?