Re: [PATCH v2] Add an Objfile.lookup_global_symbol function

Eli Zaretskii
2019-07-26T06:19:22Z

> Date: Thu, 25 Jul 2019 20:38:24 -0500
> From: "Christian Biesinger via gdb-patches" <gdb-patches@sourceware.org>
> Cc: Christian Biesinger <cbiesinger@google.com>
>
> Per the discussion in the thread about my gdb.lookup_global_symbol
> patch, I've changed this patch to only look in GLOBAL_SCOPE.
>
> This is essentially the inverse of Symbol.objfile. This allows
> handling different symbols with the same name (but from different
> objfiles) and can also be faster if the objfile is known.
>
> gdb/ChangeLog:
>
> 2019-07-25 Christian Biesinger <cbiesinger@google.com>
>
> * NEWS: Mention new function Objfile.lookup_global_symbol.
> * python/py-objfile.c (objfpy_lookup_global_symbol): New function
> Objfile.lookup_global_symbol.
>
> gdb/doc/ChangeLog:
>
> 2019-07-25 Christian Biesinger <cbiesinger@google.com>
>
> * python.texi (Objfiles In Python): Document new function
> Objfile.lookup_global_symbol.
>
> gdb/testsuite/ChangeLog:
>
> 2019-07-25 Christian Biesinger <cbiesinger@google.com>
>
> * gdb.python/py-objfile.c: Add global and static vars.
> * gdb.python/py-objfile.exp: Test new function Objfile.
> lookup_global_symbol.

Thanks, the documentation parts are OK.