From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 115898 invoked by alias); 16 Dec 2019 19:18:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 115875 invoked by uid 89); 16 Dec 2019 19:18:18 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=our X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 16 Dec 2019 19:18:17 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36513) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1igvsl-0002Oo-9Y; Mon, 16 Dec 2019 14:18:15 -0500 Received: from [176.228.60.248] (port=3427 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1igvsk-0003YK-Mp; Mon, 16 Dec 2019 14:18:15 -0500 Date: Mon, 16 Dec 2019 19:18:00 -0000 Message-Id: <83o8w83wrc.fsf@gnu.org> From: Eli Zaretskii To: Christian Biesinger CC: brobecker@adacore.com, gdb-patches@sourceware.org In-reply-to: (message from Christian Biesinger on Mon, 16 Dec 2019 12:51:28 -0600) Subject: Re: GDB 9.0.90 available for testing References: <20191211214745.E1CF0838D4@joel.gnat.com> <83tv604239.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes X-SW-Source: 2019-12/txt/msg00715.txt.bz2 > From: Christian Biesinger > Date: Mon, 16 Dec 2019 12:51:28 -0600 > Cc: Joel Brobecker , gdb-patches > > On Mon, Dec 16, 2019 at 11:23 AM Eli Zaretskii wrote: > > 2. readline/colors.c fails to compile because it uses the likes of > > S_IXGRP and S_IXOTH, which aren't defined in MinGW. The solution > > is to patch readline/posixstat.h to add the missing defines (it > > tries to do so, but makes assumptions that don't do a perfect job). > > I don't see either of those two used in colors.c? It uses S_IXUGO, which is defined via those. It also uses S_IWOTH. > > Please tell me how to go about fixing these problems on the release > > branch. Do we still maintain our separate copy of Readline, or do I > > need to report to its upstream maintainer? And what to do about > > libctf? how can I speed up the handling of those problems upstream? > > I've had some success in sending a bug report/patch to upstream > readline. Not sure about ctf. The questions is whether I fix this in our copy independently of reporting to upstream, or report upstream, and then someone updates our copy from upstream. Thanks.