From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-70213-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 8264 invoked by alias); 15 Feb 2010 18:45:55 -0000
Received: (qmail 8255 invoked by uid 22791); 15 Feb 2010 18:45:54 -0000
X-SWARE-Spam-Status: No, hits=-1.5 required=5.0 	tests=AWL,BAYES_00,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 15 Feb 2010 18:45:48 +0000
Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0KXW00M00C2O0G00@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Mon, 15 Feb 2010 20:45:44 +0200 (IST)
Received: from HOME-C4E4A596F7 ([87.70.67.249]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KXW00KUJC47FR40@a-mtaout20.012.net.il>; Mon, 15 Feb 2010 20:45:44 +0200 (IST)
Date: Mon, 15 Feb 2010 18:45:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [patch][python] Add symbol, symbol table and frame block support   to GDB API
In-reply-to: <4B796506.7010909@redhat.com>
To: Phil Muldoon <pmuldoon@redhat.com>
Cc: tromey@redhat.com, gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83mxzaxrtp.fsf@gnu.org>
References: <4B66DA35.7080701@redhat.com> <m3r5p0inxy.fsf@fleche.redhat.com> <4B796506.7010909@redhat.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-02/txt/msg00372.txt.bz2

> Date: Mon, 15 Feb 2010 15:15:18 +0000
> From: Phil Muldoon <pmuldoon@redhat.com>
> CC: gdb-patches ml <gdb-patches@sourceware.org>
> 
> Eli,
> 
> I've made that last changes you requested, too.
> 
> What do you think?

I like it.  But I want more ;-)

> +@defmethod Frame block
> +Returns the frame's code block.  @xref{Blocks In Python}.
> +@end defmethod
> +
> +@defmethod Frame function
> +Returns the symbol for the function corresponding to this frame.
> +@xref{Symbols In Python}.
> +@end defmethod
> +
>  @defmethod Frame older
>  Return the frame that called this frame.
>  @end defmethod
> @@ -20778,10 +20790,308 @@ Return the frame that called this frame.
>  Return the frame called by this frame.
>  @end defmethod
>  
> +@defmethod Frame find_sal
> +Return the frame's symtab and line object.
> +@xref{Symbol Tables In Python}.
> +@end defmethod

Sometimes "Returns", sometimes "Return".  I think the latter is
better, and we also use it more.  In any case, we should use one or
the other consistently.

> +Please see @ref{Frames In Python} for a more in-depth discussion on
> +frames.  Furthermore, see @ref{Stack, ,Examining the Stack} for more
> +detailed technical information on @value{GDBN}'s book-keeping of the
> +stack.

Please add a comma after the right brace that closes the argument of
@ref (two counts above).  Otherwise, makeinfo will bitch at you.

Thanks.