From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-70361-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 12644 invoked by alias); 20 Feb 2010 13:39:53 -0000
Received: (qmail 12635 invoked by uid 22791); 20 Feb 2010 13:39:53 -0000
X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 	tests=AWL,BAYES_00,RCVD_IN_SORBS_WEB,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 20 Feb 2010 13:39:46 +0000
Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0KY50060073PTK00@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Sat, 20 Feb 2010 15:39:43 +0200 (IST)
Received: from HOME-C4E4A596F7 ([84.228.213.68]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KY50030G7A60S90@a-mtaout22.012.net.il>; Sat, 20 Feb 2010 15:39:43 +0200 (IST)
Date: Sat, 20 Feb 2010 13:39:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: Multiexec MI
In-reply-to: <201002201354.56081.vladimir@codesourcery.com>
To: Vladimir Prus <vladimir@codesourcery.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83mxz4vxep.fsf@gnu.org>
References: <201001132329.30212.vladimir@codesourcery.com> <201002192254.14750.vladimir@codesourcery.com> <83tytdvsxl.fsf@gnu.org> <201002201354.56081.vladimir@codesourcery.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-02/txt/msg00520.txt.bz2

> From: Vladimir Prus <vladimir@codesourcery.com>
> Date: Sat, 20 Feb 2010 13:54:55 +0300
> Cc: gdb-patches@sourceware.org
> 
> >   The @var{thread-group} field, if present, specifies the id of the
> >   thread group in whose context the library was loaded. 
> > 
> > Does this express what you meant?
> 
> Oh, it does. Thanks.
>  
> > > > > +Identifier of the thread group.  This field is always present.  The
> > > > > +identifier is an opaque string, and is not necessary an integer.
> > > >                                               ^^^^^^^^^
> > > > "necessarily"
> > > > 
> > > > Also, "is an opaque string, and is not necessarily an integer" sounds
> > > > strange: if it's a string, how can it be an integer?  Do you mean to
> > > > say that the string includes non-digit characters?
> > > 
> > > How about: "The identifier is an opaque string; frontends should not
> > > try to convert it to integer".
> > 
> > I suggest a slight variation:
> > 
> >   The identifier is an opaque string; frontends should not try to
> >   convert it to an integer, even though it might look like one.
> 
> I've used your wording. Revised patch attached.

It's okay, but please fix this small typo when you commit:

> --- a/gdb/doc/observer.texi
> +++ b/gdb/doc/observer.texi
> @@ -199,13 +199,23 @@ The thread's ptid has changed.  The @var{old_ptid} parameter specifies
>  the old value, and @var{new_ptid} specifies the new value.
>  @end deftypefun
>  
> -@deftypefun void inferior_appeared (int @var{pid})
> -@value{GDBN} has attached to a new inferior identified by @var{pid}.
> +@deftypefun void inferior_added (struct inferior *@var{inf})
> +The inferior @var{inf} has been added to the list of inferior.  At
                                                        ^^^^^^^^
This should be "inferiors".

Thanks.