From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-91890-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 8375 invoked by alias); 8 Jun 2012 07:13:08 -0000
Received: (qmail 8357 invoked by uid 22791); 8 Jun 2012 07:13:05 -0000
X-SWARE-Spam-Status: No, hits=-4.1 required=5.0	tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,RCVD_IN_HOSTKARMA_YE,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 08 Jun 2012 07:12:52 +0000
Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0M5A00800EJ97400@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Fri, 08 Jun 2012 10:12:50 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([87.69.210.75]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0M5A008JKEPE4O40@a-mtaout20.012.net.il>; Fri, 08 Jun 2012 10:12:50 +0300 (IDT)
Date: Fri, 08 Jun 2012 07:13:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH/doc] IPA protocol doc
In-reply-to: <4FD195CA.7060607@codesourcery.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83mx4euvik.fsf@gnu.org>
References: <1339076026-31158-1-git-send-email-yao@codesourcery.com> <83y5nzukr6.fsf@gnu.org> <4FD195CA.7060607@codesourcery.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-06/txt/msg00223.txt.bz2

> Date: Fri, 8 Jun 2012 14:03:54 +0800
> From: Yao Qi <yao@codesourcery.com>
> CC: <gdb-patches@sourceware.org>
> 
> This new patch address all the problems you pointed out.  Is it OK?

Yes, with two comments:

> gdb/doc:
> 	* gdb.texinfo (In-Process Agent): Add 'In-Process Agent
> 	Protocol'.
> 	(Tracepoint Packets): Add anchors.

Please mention here all the new nodes you added, like this:

	(In-Process Agent Protocol, IPA Protocol Objects)
	(IPA Protocol Commands): New nodes.

> +@multitable @columnfractions .30 .20 .50
> +@headitem Name @tab Size @tab Description
> +@item @emph{agent expression object} @tab @tab

Please add a short description of this table, something like this:

  The following table describes important attributes of each IPA
  object:

OK with these changes.

Thanks.