From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15234 invoked by alias); 18 Oct 2012 17:33:39 -0000 Received: (qmail 14946 invoked by uid 22791); 18 Oct 2012 17:33:38 -0000 X-SWARE-Spam-Status: No, hits=-4.5 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 18 Oct 2012 17:33:33 +0000 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0MC300500NC99C00@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Thu, 18 Oct 2012 19:33:31 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MC3005V7NFV6E20@a-mtaout20.012.net.il>; Thu, 18 Oct 2012 19:33:31 +0200 (IST) Date: Thu, 18 Oct 2012 17:33:00 -0000 From: Eli Zaretskii Subject: Re: [PATCH] Fix PR14617: New MI notification on tracepoint modified. In-reply-to: <1350556586-12800-1-git-send-email-yao@codesourcery.com> To: Yao Qi Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83mwzj1y83.fsf@gnu.org> References: <1350556586-12800-1-git-send-email-yao@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00336.txt.bz2 > From: Yao Qi > Date: Thu, 18 Oct 2012 18:36:26 +0800 > > As PR gdb/14617 described, when the passcount of a tracepoint is > modified, GDB doesn't emit any notification. This patch adds a > new notification '=tracepoint-modified' for the changes to > tracepoint-specific attributes. The reason I don't use > '=breakpoint-modified' notification is that IMO, it is about > changes to general breakpoints (breakpoint, tracepoint, catchpoint, > etc), so I don't want to put tracepoint-specific stuff into > it. > > Regression tested on x86_64-linux with both native and gdbserver, > OK to apply? The documentation parts are OK. Thanks.