From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8350 invoked by alias); 25 Oct 2012 17:31:14 -0000 Received: (qmail 8331 invoked by uid 22791); 25 Oct 2012 17:31:11 -0000 X-SWARE-Spam-Status: No, hits=-4.5 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,RCVD_IN_HOSTKARMA_YE,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 25 Oct 2012 17:31:00 +0000 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MCG00K00LWYYR00@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Thu, 25 Oct 2012 19:30:59 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MCG00KD3LZMO890@a-mtaout22.012.net.il>; Thu, 25 Oct 2012 19:30:59 +0200 (IST) Date: Thu, 25 Oct 2012 17:31:00 -0000 From: Eli Zaretskii Subject: Re: [PATCH] target attributes [5/5] doc In-reply-to: To: Hui Zhu Cc: hui_zhu@mentor.com, gdb-patches@sourceware.org, stan_shebs@mentor.com Reply-to: Eli Zaretskii Message-id: <83mwzaa27c.fsf@gnu.org> References: <503DCEE4.2010706@mentor.com> <83sjb2q2yw.fsf@gnu.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00503.txt.bz2 > From: Hui Zhu > Date: Sun, 2 Sep 2012 19:20:01 +0800 > Cc: Hui Zhu , gdb-patches@sourceware.org, stan_shebs@mentor.com > > Oops. I am so sorry that I post a old version of this patch. So > sorry about that. > The attachment is the right version. Please help me with it. Sorry for the long delay. > +@kindex maint load-target-attributes > +@item maint load-target-attributes @var{filename} > +Load @ref{Target Attributes} from an XML file. Please don't let @ref serve double duty, it looks ugly in the manual. Something like this is better: Load target attributes (@pxref{Target Attributes}) from an XML file. > +@kindex maint clear-target-attributes > +@item maint clear-target-attributes > +Remove all @ref{Target Attributes}. Same here. > +@smallexample > + > + > + > + > + > + > + > + > +
> +
> + > + > + > + > + > + > + > + > + > + > +@end smallexample A few lines in this @smallexample will overflow the page dimensions; please break them in two lines. > +If @samp{target-only-cond-check} set to @samp{yes}, GDB will not check the ^^^ @value{GDBN} > +condition of breakpoint in its side. If @samp{target-only-cond-check} not > +define, it means @samp{no}. ^^^^^^ "defined" > +@smallexample > + > +@end smallexample Too long, please break into 2 lines. > +This define the breakpoint address range that a target attribute can ^^^^^^ "defines" > +be used in the condition or commands of the breakpoints that are > +inside this address range. If address is defined, this target > +attribute supports any address. ^^^^^^^^^^^^^^^^^ Did you mean "not defined"? > +Target attributes may be used in breakpoint conditions and actions, > +as well as being included in expressions and print commands. The ^^^^^ "be" > +of all the breakpoints will reset to 0 when the inferior stops and ^^^^^^^^^^ "will be reset" > +@smallexample > +(gdb) target remote :1234 > +Remote debugging using :1234 > +Reading symbols from /lib64/ld-linux-x86-64.so.2...(no debugging symbols found)...done. This line is too long, please break it in 2. OK with these changes. Thanks.