From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-100332-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 25940 invoked by alias); 9 Apr 2013 19:49:51 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 25928 invoked by uid 89); 9 Apr 2013 19:49:51 -0000
X-Spam-SWARE-Status: No, score=-4.3 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,SPF_SOFTFAIL autolearn=no version=3.3.1
Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 09 Apr 2013 19:49:50 +0000
Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0ML000L006ONWH00@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Tue, 09 Apr 2013 22:49:46 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0ML000LVH72YBKD0@a-mtaout20.012.net.il>; Tue, 09 Apr 2013 22:49:46 +0300 (IDT)
Date: Wed, 10 Apr 2013 04:44:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH] Display configuration details in --help
In-reply-to: <CADPb22QrNAtK_5uFRyyxvwi38ck-mQP++BqVO3CRSzT0B=GkRA@mail.gmail.com>
To: Doug Evans <dje@google.com>
Cc: tromey@redhat.com, brobecker@adacore.com, palves@redhat.com, gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83mwt7a3h4.fsf@gnu.org>
References: <83r4jaynqq.fsf@gnu.org> <CADPb22R4o4gkQk8oeqGvmWZerVf7gdkw8XOKz9mYxD6ubFPRig@mail.gmail.com> <514B4AC3.1090103@redhat.com> <83zjxwy4ux.fsf@gnu.org> <20130321191051.GF5447@adacore.com> <83r4j8y1kh.fsf@gnu.org> <20130321203919.GG5447@adacore.com> <87r4j8zd0k.fsf@fleche.redhat.com> <83ehf85u7x.fsf@gnu.org> <83wqsbadfe.fsf@gnu.org> <20836.17485.525118.795474@ruffy2.mtv.corp.google.com> <83txnfa9m7.fsf@gnu.org> <CADPb22SQaWrBd4MOmMqFaAMc=KnX15hd=be3Ta_u3wGg=HGmXQ@mail.gmail.com> <83sj2za65y.fsf@gnu.org> <CADPb22QrNAtK_5uFRyyxvwi38ck-mQP++BqVO3CRSzT0B=GkRA@mail.gmail.com>
X-SW-Source: 2013-04/txt/msg00258.txt.bz2

> Date: Tue, 9 Apr 2013 12:31:16 -0700
> From: Doug Evans <dje@google.com>
> Cc: Tom Tromey <tromey@redhat.com>, Joel Brobecker <brobecker@adacore.com>, 
> 	Pedro Alves <palves@redhat.com>, gdb-patches <gdb-patches@sourceware.org>
> 
> On Tue, Apr 9, 2013 at 11:51 AM, Eli Zaretskii <eliz@gnu.org> wrote:
> >> >>  > +  fprintf_filtered (stream, _("\
> >> >>  > +             --without-expat\n\
> >> >>  > +"));
> >> >>  > +#endif
> >> >>
> >> >> If we've already discussed this, please ignore, but ... :-)
> >> >> I'd prefer one line per fprintf instead of three.
> >> >
> >> > Sorry, I'm not following: what 3 lines?  Can you show how would you
> >> > like the code be reformatted?
> >>
> >>   fprintf_filtered (stream, _("  -with-expat\n"));  // assuming 2
> >> space indentation
> >
> > OK, I used the style I did because it makes it much easier to keep the
> > alignment visible, without the need to count characters and columns.
> 
> I'm not sure.  13 is a lot to visualize and given the vertical span
> it's not straightforward, to me anyway.
> 
> Using a more explicit form for the indentation (making it a parameter
> to the printf) works better for me if the amount of indentation is
> going to be that much.

These are minor stylistic issues, really just personal preferences.
Are they important enough to block the commit?