From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15496 invoked by alias); 26 Mar 2015 18:53:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15483 invoked by uid 89); 26 Mar 2015 18:53:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mtaout20.012.net.il Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 26 Mar 2015 18:53:53 +0000 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0NLU00C001GSIK00@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Thu, 26 Mar 2015 20:53:12 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NLU00CUC1SN6IB0@a-mtaout20.012.net.il>; Thu, 26 Mar 2015 20:53:12 +0200 (IST) Date: Thu, 26 Mar 2015 18:53:00 -0000 Sun-Java-System-SMTP-Warning: Lines longer than SMTP allows found and truncated. From: Eli Zaretskii Subject: Re: [RFC] [PATCH] Provide the ability to write the frame unwinder in Python In-reply-to: To: Alexander Smundak Cc: dje@google.com, wingo@igalia.com, gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83mw2zmvzf.fsf@gnu.org> References: <21714.40641.510825.30998@ruffy2.mtv.corp.google.com> <54E71694.1080304@redhat.com> <87ioei31uj.fsf@igalia.com> <87d24p19tt.fsf@igalia.com> <54FD7DAA.7010603@redhat.com> <87twxrncld.fsf@igalia.com> <87ioe1dvu2.fsf@igalia.com> <87sid4atms.fsf@igalia.com> <87r3smado6.fsf@igalia.com> X-IsSubscribed: yes X-SW-Source: 2015-03/txt/msg00865.txt.bz2 > Date: Wed, 25 Mar 2015 20:31:09 -0700 > From: Alexander Smundak > Cc: Andy Wingo , gdb-patches > > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -12,6 +12,7 @@ > ** gdb.Objfile objects have a new attribute "username", > which is the name of the objfile as specified by the user, > without, for example, resolving symlinks. > + ** You can now write frame unwinders in Python. This part is OK. > +@node Unwinding Frames in Python > +@subsubsection Unwinding Frames in Python > +@cindex Unwinding frames in Python. @cindex entries should generally begin with a lower-case letter. That's because alphabetic sorting in various locales might produce different orders when mixed-case letters are involved, so the order in the Index nodes will be different depending on where the manual was produced. We want to avoid that. > +In GDB terminology ``unwinding'' is the process of finding the ^^^ "@value{GDBN}" (here and elsewhere in the patch). > +previous frame (that is, caller's) from the current one. An unwinder ^^ Two spaces between sentences (here and elsewhere in the patch). > +(for example, and application running Java Virtual Machine) sometimes ^^^ "an" > +returns an object (an instance of gdb.UnwindInfo class) describing ^^^^^^^^^^^^^^ This should be in @code, as it's a Python symbol. > +usually found in the corresponding xxx-@code{tdep.h} file in the gdb ^^^^^^^^^^^^^^^^^ It is better to write @file{@var{platform}-tdep.h} here; this explains better what is that "xxx" in the text. > +It also provides a factory method to create a gdb.UnwindInfo instance ^^^^^^^^^^^^^^ @code > +using one of the @code{frame_id_build_xxx} functions. The exact Once again, please try a way to make "xxx" more clear, as I did above. Thanks.