Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Anton Kolesov <Anton.Kolesov@synopsys.com>
Cc: gdb-patches@sourceware.org, Francois.Bedard@synopsys.com,
	palves@redhat.com
Subject: Re: [PATCH v3] arc: New Synopsys ARC port
Date: Mon, 19 Sep 2016 17:02:00 -0000	[thread overview]
Message-ID: <83mvj3hlhr.fsf@gnu.org> (raw)
In-Reply-To: <1474288598-6318-1-git-send-email-Anton.Kolesov@synopsys.com>	(message from Anton Kolesov on Mon, 19 Sep 2016 15:36:38 +0300)

> From: Anton Kolesov <Anton.Kolesov@synopsys.com>
> Cc: Anton Kolesov <Anton.Kolesov@synopsys.com>,
> 	Francois Bedard <Francois.Bedard@synopsys.com>,
> 	Pedro Alves <palves@redhat.com>,
> 	Eli Zaretskii <eliz@gnu.org>
> Date: Mon, 19 Sep 2016 15:36:38 +0300
> 
> Changes in V3:
> 
>     * Documentation fixes.
>     * Fix invalid filenames in features/Makefile.
>     * Remove all explicit regnums registers from XML features.  Requirement for
>       those specific regnums was removed in V2 of this patch, but XML files
>       haven't been updated for V2.
>     * Remove LP_START and LP_END from XML features, because they are not
>       required.
>     * C files were regenerated with new XML sources.

The documentation is approved with one minor nit:

> +ARC processors are highly configurable, so even core registers and their number
> +are not completely predetermined.  In addition flags and PC registers which are
> +important to @value{GDBN} are not "core" registers in ARC.  It is required that
                                     ^^^^^^

Please use ``core'' instead, it produces a nicer output.

Thanks.


  reply	other threads:[~2016-09-19 17:02 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-31  8:50 [PATCH 1/2] " Anton Kolesov
2016-08-31  8:50 ` [PATCH 2/2] Add myself as a write-after-approval GDB maintainer Anton Kolesov
2016-08-31 13:59 ` [PATCH 1/2] arc: New Synopsys ARC port Pedro Alves
2016-09-01 19:54   ` Anton Kolesov
2016-09-05 18:56     ` Pedro Alves
2016-09-15 11:39     ` Pedro Alves
2016-09-16 17:12       ` [PATCH v2] " Anton Kolesov
2016-09-16 17:54         ` Pedro Alves
2016-09-16 18:32         ` Eli Zaretskii
2016-09-16 18:33           ` Pedro Alves
2016-09-19 12:37             ` [PATCH v3] " Anton Kolesov
2016-09-19 17:02               ` Eli Zaretskii [this message]
2016-09-21 15:40                 ` [PATCH v4] " Anton Kolesov
2016-09-21 16:17                   ` Pedro Alves
2016-09-21 17:29                     ` Anton Kolesov
2016-09-21 17:30                       ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83mvj3hlhr.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=Anton.Kolesov@synopsys.com \
    --cc=Francois.Bedard@synopsys.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox