From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 116328 invoked by alias); 8 May 2017 15:02:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 116311 invoked by uid 89); 8 May 2017 15:02:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 08 May 2017 15:02:01 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d7kAi-00045e-1H for gdb-patches@sourceware.org; Mon, 08 May 2017 11:02:02 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53097) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d7kAh-00045a-U9 for gdb-patches@sourceware.org; Mon, 08 May 2017 11:01:59 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1486 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1d7kAh-00072E-9H for gdb-patches@sourceware.org; Mon, 08 May 2017 11:01:59 -0400 Date: Mon, 08 May 2017 15:02:00 -0000 Message-Id: <83mvancrze.fsf@gnu.org> From: Eli Zaretskii To: gdb-patches@sourceware.org In-reply-to: <20170504194442.63AAF60B72@joel.gnat.com> (message from Joel Brobecker on Thu, 4 May 2017 12:44:42 -0700 (PDT)) Subject: Re: GDB 7.99.91 MinGW compilation warning in tui.c Reply-to: Eli Zaretskii References: <20170504194442.63AAF60B72@joel.gnat.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg00187.txt.bz2 The warning manifests itself as follows: g++ -std=gnu++11 -O2 -gdwarf-4 -g3 -I. -I. -I./common -I./config -DLOCALEDIR="\"d:/usr/share/locale\"" -DHAVE_CONFIG_H -I./../include/opcode -I./../opcodes/.. -I./../readline/.. -I../bfd -I./../bfd -I./../include -I../libdecnumber -I./../libdecnumber -I./gnulib/import -Ibuild-gnulib/import -DTUI=1 -Id:/usr/include -Id:/usr/include/guile/2.0 -Id:/usr/include -Id:/usr/Python26/include -Id:/usr/Python26/include -Wall -Wpointer-arith -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts -Wempty-body -Wunused-but-set-parameter -Wunused-but-set-variable -Wno-sign-compare -Wno-narrowing -Wno-format -c -o tui.o -MT tui.o -MMD -MP -MF .deps/tui.Tpo tui/tui.c tui/tui.c: In function 'void tui_enable()': tui/tui.c:430:39: warning: ISO C++ forbids converting a string constant to 'char*' [-Wwrite-strings] s = newterm ("unknown", stdout, stdin); ^ I fixed this by explicitly casting "unknown" to 'char *' -- is that the right fix? Is it OK to push that fix? Thanks.