From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16637 invoked by alias); 1 Mar 2018 14:48:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 120373 invoked by uid 89); 1 Mar 2018 14:48:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.8 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_1,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 01 Mar 2018 14:48:20 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1erPVA-000383-MW for gdb-patches@sourceware.org; Thu, 01 Mar 2018 09:48:13 -0500 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53890) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1erPVA-00037n-IQ; Thu, 01 Mar 2018 09:48:08 -0500 Received: from [176.228.60.248] (port=4582 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1erPV9-0002Lt-W3; Thu, 01 Mar 2018 09:48:08 -0500 Date: Thu, 01 Mar 2018 14:48:00 -0000 Message-Id: <83muzryhql.fsf@gnu.org> From: Eli Zaretskii To: "Metzger\, Markus T" CC: gdb-patches@sourceware.org In-reply-to: (markus.t.metzger@intel.com) Subject: Re: [PATCH 2/2] btrace: set/show record btrace cpu Reply-to: Eli Zaretskii References: <1519379570-16643-1-git-send-email-markus.t.metzger@intel.com> <1519379570-16643-2-git-send-email-markus.t.metzger@intel.com> <83woz34xuj.fsf@gnu.org> <83lgff1s4n.fsf@gnu.org> <83y3jez3yw.fsf@gnu.org> <83po4pyvji.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2018-03/txt/msg00024.txt.bz2 > From: "Metzger, Markus T" > CC: "gdb-patches@sourceware.org" > Date: Thu, 1 Mar 2018 07:05:42 +0000 > > > > > @cindex processor errata > > > > @dfn{Processor errata} are bugs in processor firmware that can cause > > > > a trace not to match the specification. Trace decoders that are > > > > unaware of these errata might fail to decode such a trace. > > > > @value{GDBN} can detect erroneous trace packets and correct them, > > > > thus avoiding the decoding failures. These corrections are known as > > > > @dfn{errata workarounds}, and are enabled based on the processor on > > > > which the trace was recorded. > > > > > But that completely loses the explanation of what the errata are. If my > > explanation is not accurate, let's correct it, rather than deleting it. > > I didn't mean to delete your explanation. I only removed the 'firmware' part. The text I proposed is above. It begins with an explanation of what those errata are, and why they are detrimental to btrace. The text you proposed instead is this: Errata may cause the recorded trace to not match the specification. This, in turn, may cause trace decode to fail. @value{GDBN} can detect erroneous trace packets and correct them, thus avoiding the decoding failures. These corrections are known as @dfn{errata workarounds}, and are enabled based on the processor on which the trace was recorded. This just says that trace decode can fail, but tells nothing about the phenomenon itself. Thus my "completely loses" reaction. But I don't want to argue. If you feel that the text you wrote is good enough, go ahead and push it, even though I'm unhappy. Thanks.