From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 45491 invoked by alias); 23 Mar 2019 13:11:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 45482 invoked by uid 89); 23 Mar 2019 13:11:27 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.7 required=5.0 tests=AWL,BAYES_40,BODY_8BITS,GARBLED_BODY,SPF_PASS autolearn=no version=3.3.1 spammy=English, english, HX-Languages-Length:845, vilgeforce@gmail.com X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 23 Mar 2019 13:11:25 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:34169) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h7gQl-00048A-Ha; Sat, 23 Mar 2019 09:11:23 -0400 Received: from [176.228.60.248] (port=3491 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1h7gQk-00047K-Jq; Sat, 23 Mar 2019 09:11:23 -0400 Date: Sat, 23 Mar 2019 13:11:00 -0000 Message-Id: <83mullpwg6.fsf@gnu.org> From: Eli Zaretskii To: =?utf-8?B?0JLQu9Cw0LTQuNC80LjRgCDQnNCw0YDRgtGM0Y/QvdC+0LI=?= CC: gdb-patches@sourceware.org In-reply-to: (message from =?utf-8?B?0JLQu9Cw0LTQuNC80LjRgCDQnNCw0YDRgtGM0Y/QvdC+0LI=?= on Sat, 23 Mar 2019 14:59:05 +0300) Subject: Re: [PATCH][PR server/24377] Fix mixing English and system default languages in error messages on Windows References: MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes X-SW-Source: 2019-03/txt/msg00498.txt.bz2 > From: Владимир Мартьянов > Date: Sat, 23 Mar 2019 14:59:05 +0300 > > The fourth argument of FormatMessage() in strwinerror() in file > win32-low.c is set to zero. Thus, Windows could use system default > locale to translate error codes to error message. At the same time, > gdbserver have hardcoded English error messages ("Error creating > process..." for example). As a result, server could display error > messages with mixed languages. > > I made a patch to use en_US locale in FormatMessage, so all error > messages will be in English. Thanks, but isn't this a step backward? Would it make sense to have the hard-coded messages be translated instead? Or is that impossible for some reason?