From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-157709-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 94496 invoked by alias); 23 Jul 2019 14:47:55 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 94488 invoked by uid 89); 23 Jul 2019 14:47:55 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=H*r:4.82, H*r:sk:RSA_AES, H*r:sk:fencepo, H*r:2001
X-HELO: eggs.gnu.org
Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 23 Jul 2019 14:47:54 +0000
Received: from fencepost.gnu.org ([2001:470:142:3::e]:55683)	by eggs.gnu.org with esmtp (Exim 4.71)	(envelope-from <eliz@gnu.org>)	id 1hpw50-0002Km-Mv; Tue, 23 Jul 2019 10:47:51 -0400
Received: from [176.228.60.248] (port=2933 helo=home-c4e4a596f7)	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)	(Exim 4.82)	(envelope-from <eliz@gnu.org>)	id 1hpw4z-0002Qd-QJ; Tue, 23 Jul 2019 10:47:50 -0400
Date: Tue, 23 Jul 2019 14:47:00 -0000
Message-Id: <83muh4q039.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Simon Marchi <simark@simark.ca>
CC: cbiesinger@google.com, gdb-patches@sourceware.org
In-reply-to: <54adbe2b-3501-52ea-fdac-5a44f7869391@simark.ca> (message from	Simon Marchi on Mon, 22 Jul 2019 21:30:08 -0400)
Subject: Re: [PATCH] Add an Objfile.lookup_global_symbol function
References: <20190625220832.247935-1-cbiesinger@google.com> <20190722205121.89189-1-cbiesinger@google.com> <54adbe2b-3501-52ea-fdac-5a44f7869391@simark.ca>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-IsSubscribed: yes
X-SW-Source: 2019-07/txt/msg00537.txt.bz2

> From: Simon Marchi <simark@simark.ca>
> Date: Mon, 22 Jul 2019 21:30:08 -0400
> 
> > +  { "lookup_global_symbol", (PyCFunction) objfpy_lookup_global_symbol,
> > +    METH_VARARGS | METH_KEYWORDS,
> > +    "lookup_global_symbol (name [, domain]).\n\
> > +Looks up a global symbol in this objfile and returns it." },
> > +
> 
> To be consistent with the rest of the Python function help strings, I think it should
> be
> 
>   "Look up a global symbol in this objfile and return it."
> 
> i.e. not at the third person of the singular.  Eli, could you tell which form is preferred?

Your (Simon's) suggestion is the preferred form.

Thanks.