Re: [PATCH 1/7] gdb: Add new -n flag to some info commands

Eli Zaretskii
2019-07-27T16:41:15Z

> From: Andrew Burgess <andrew.burgess@embecosm.com>
> Cc: Richard Bunt <Richard.Bunt@arm.com>, Andrew Burgess <andrew.burgess@embecosm.com>
> Date: Sat, 27 Jul 2019 17:22:29 +0100
>
> index cc1d58520d4..40b56727227 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -215,6 +215,10 @@ maint show test-options-completion-result
> printing of some header information in a similar fashion to "info
> variables" and "info functions".
>
> + ** The "info variables", "info functions", and "whereis" commands
> + now take a '-n' flag that excludes non-debug symbols from the
> + results.

I'm afraid "non-debug symbols" will not be self-explanatory enough.
Can we say something more concrete here, or at least give a couple of
examples?

> +By default, the command will include non-debug symbols in the output\n\
> +these can be excluded using the -n flag." : ""));

I believe we need a semi-colon after "output".

> +Non-debug symbols are also included in the results if the symbols are
> +of a type that indicates they might be for executable code. The
> +@samp{-n} flag excludes non-debugging symbols from the results.

Please add here text that explains what are "non-debug symbols". I
also had difficulty understanding what does "a type that indicates
they might be for executable code" means, so maybe clarify that as
well.

> @@ -18587,11 +18591,15 @@
> language of the variable, other values mean to use
> the manually specified language (see @ref{Manually, ,Set Language Manually}).
>
> +Non-debug symbols are also included in the results if the symbols are
> +of a type that indicates they might be for data objects. The
> +@samp{-n} flag excludes non-debugging symbols from the results.

Same here.

Thanks.