From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eliz@gnu.org>
Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10])
 by sourceware.org (Postfix) with ESMTPS id DEBB43857C71
 for <gdb-patches@sourceware.org>; Fri, 24 Jul 2020 10:32:33 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DEBB43857C71
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=gnu.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=eliz@gnu.org
Received: from fencepost.gnu.org ([2001:470:142:3::e]:43301)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1jyv0D-0001VU-G7; Fri, 24 Jul 2020 06:32:33 -0400
Received: from [176.228.60.248] (port=2890 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1jyv0C-00080j-QH; Fri, 24 Jul 2020 06:32:33 -0400
Date: Fri, 24 Jul 2020 13:32:17 +0300
Message-Id: <83mu3pdwzy.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org
In-Reply-To: <be3ee9b06bd5f820a99d2293bc3a36c018670b0d.1595584512.git.andrew.burgess@embecosm.com>
 (message from Andrew Burgess on Fri, 24 Jul 2020 10:57:51 +0100)
Subject: Re: [PATCH 1/2] gdb: Add a find method for RegisterDescriptorIterator
References: <cover.1595584512.git.andrew.burgess@embecosm.com>
 <be3ee9b06bd5f820a99d2293bc3a36c018670b0d.1595584512.git.andrew.burgess@embecosm.com>
X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Fri, 24 Jul 2020 10:32:34 -0000

> From: Andrew Burgess <andrew.burgess@embecosm.com>
> Date: Fri, 24 Jul 2020 10:57:51 +0100
> 
> +It is also possible to lookup a register descriptor based on its name
> +using the following @code{gdb.RegisterDescriptorIterator} function:
> +
> +@defun RegisterDescriptorIterator.find ( @var{name} )
                                           ^          ^
Please remove these extra blanks, they are against our coding
conventions.

> +Returns a @code{gdb.RegisterDescriptor} for the register with name
> +@var{name}, or @code{None} if there is no register with that name.
> +@end defun

Is it necessary or useful to say what kind of data type is NAME?  Or
will this be obvious to any Python programmer?

Thanks.