From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id W5abOZjDp2UQmD4AWB0awg (envelope-from ) for ; Wed, 17 Jan 2024 07:10:00 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=WAVrRoaZ; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id E0E141E0C3; Wed, 17 Jan 2024 07:10:00 -0500 (EST) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A718F1E092 for ; Wed, 17 Jan 2024 07:09:58 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2B756385C32C for ; Wed, 17 Jan 2024 12:09:58 +0000 (GMT) Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 127883858C62 for ; Wed, 17 Jan 2024 12:09:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 127883858C62 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 127883858C62 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705493378; cv=none; b=BimJp+xB2enGw5bG+h2v4o3nBM2RRBNDuCM5+GGNStkYb32hnd8otNpTctJpqWA/AGySdkU7P4+jrUjIYq75SZd4MVn8e7gARL0FH52C1IF6RiEaSLK0RKIV0PLXdVrSnGnPTWeAVUNxGCHPnOh2VlCTx8hGBigTLQHbR2ggcrU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705493378; c=relaxed/simple; bh=5BMQxroLz/YwfJ9DxOAyTngkn/qM+ka0ug8AA9qZql0=; h=DKIM-Signature:Date:Message-Id:From:To:Subject; b=OqnDntqtgQt4TrztbJYgpl30RsNzXZciRdnwRlo89tlbu9YqvipI/0VN20ZZE4rIctWcrCtT5WghU3BvJ3ogHIyKPX9osOjYMZe1GIL0w3fBo8uzexJRNMZuJhMXgZt9nk/8E8QPKdn3GjYySwegNJYNg7iqScvYAM8GD68Mk6s= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rQ4jg-0003up-8Q; Wed, 17 Jan 2024 07:09:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=a2/qw1te45oSF732/Wz3fBgvJTdmELBg/6lnvHUjTXE=; b=WAVrRoaZCPgF X9TDSAd98Cb158OYmRqbtMJ8Tn4dGoA+bxnlUfRFhSUtKT8ZoZ3tXz/S45nee5Rrn25SffV3s+0AS j1J71ecHKkqTDM5MvguEZp5iPukn3ILLa+5mbJGDvE2IsTJq8NvOUW0fUBDrCBT9V8lQFmvo/UtTy VCyy47QZe+wofzAX03EPLG5tuJO40VR4IEh8tX4WmuJTtlvCVO0MMbFq/wT/eYi7Q6JeST8F4CIN/ BFpK6t9HEdWm3IJwPOsbrzAnZ3hzYoyRlNVTCUd3tK7u8VClfUDc/yINzS9g5vl7rtHtgnUWK9ciG xbEe5R2WmHS0dFWy65wb+g==; Date: Wed, 17 Jan 2024 14:09:28 +0200 Message-Id: <83mst4b1qf.fsf@gnu.org> From: Eli Zaretskii To: Andrew Burgess , Hannes Domani Cc: gdb-patches@sourceware.org In-Reply-To: <048fa74bfb249273becb517d9edc9fd7a129e205.1705439706.git.aburgess@redhat.com> (message from Andrew Burgess on Tue, 16 Jan 2024 21:24:02 +0000) Subject: Re: [PATCH 5/5] gdb: remove special case completion word handling for filenames References: <048fa74bfb249273becb517d9edc9fd7a129e205.1705439706.git.aburgess@redhat.com> X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org > From: Andrew Burgess > Cc: Andrew Burgess , > Eli Zaretskii > Date: Tue, 16 Jan 2024 21:24:02 +0000 > > Eli, > > CC-ing you directly as the work I'm touching was originally done by > you, see: > > https://sourceware.org/pipermail/gdb-patches/2001-February/007313.html > > The original email mentions 4 cases: > > - completion on a file name in a list of file names didn't work; > - GDB would not always append a slash if the completion is a directory; > - completion failed when the file name had non-file-name characters, > such as redirection, around it; > - on DOS/Windows, completion would fail with files with a drive letter. > > I believe I've tested the first 3 of these and they all seem to work > fine still, but I don't have a working Windows machine on which I can > test case #4. I just wanted to bring this change to your attention in > case you wanted to build/test this and check that completion around > drive letters was still working as expected. Thanks. I won't have enough time for this soon enough, unfortunately. Maybe someone else could do that? I've taken the liberty of CC'ing Hannes, in the hope that he could find some time for this soon.