From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-70012-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 2339 invoked by alias); 5 Feb 2010 18:06:53 -0000
Received: (qmail 2326 invoked by uid 22791); 5 Feb 2010 18:06:52 -0000
X-SWARE-Spam-Status: No, hits=-0.3 required=5.0 	tests=AWL,BAYES_40,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 05 Feb 2010 18:06:47 +0000
Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0KXD00500RFB8D00@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Fri, 05 Feb 2010 20:06:44 +0200 (IST)
Received: from HOME-C4E4A596F7 ([87.70.67.249]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KXD00KM7RN4T5L0@a-mtaout22.012.net.il>; Fri, 05 Feb 2010 20:06:40 +0200 (IST)
Date: Fri, 05 Feb 2010 18:06:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [patch][python] Add symbol, symbol table and frame block support   to GDB API
In-reply-to: <4B6BF88B.10304@redhat.com>
To: Phil Muldoon <pmuldoon@redhat.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83ljf7ftfy.fsf@gnu.org>
References: <4B66DA35.7080701@redhat.com> <83sk9khe3b.fsf@gnu.org> <4B67FD58.5050504@redhat.com> <83hbpzgztm.fsf@gnu.org> <4B69E2C6.3090509@redhat.com> <4B6BF88B.10304@redhat.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-02/txt/msg00171.txt.bz2

> Date: Fri, 05 Feb 2010 10:52:59 +0000
> From: Phil Muldoon <pmuldoon@redhat.com>
> CC: gdb-patches@sourceware.org
> 
> On 02/03/2010 08:55 PM, Phil Muldoon wrote:
> > On 02/02/2010 08:14 PM, Eli Zaretskii wrote:
> > 
> > I've attached an updated patch.  What do you think?
> > 
> 
> 
> I thought I'd nip in with another quick patch in-between this review.
> I fixed a few nits. Apologies for this, but this patch should be
> considered the latest.

Same comments as before.  And maybe one more (sorry I didn't catch
that before):

> +@defivar Block function
> +The name of the block represented as a @code{gdb.Symbol}.  If the
> +block is not named, then this attribute returns @code{None}.  This
                                           ^^^^^^^
"holds", not "returns".