From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2662 invoked by alias); 15 Dec 2010 18:17:11 -0000 Received: (qmail 2654 invoked by uid 22791); 15 Dec 2010 18:17:10 -0000 X-SWARE-Spam-Status: No, hits=-1.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout21.012.net.il (HELO mtaout21.012.net.il) (80.179.55.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 15 Dec 2010 18:16:59 +0000 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0LDH00M00DFEAQ00@a-mtaout21.012.net.il> for gdb-patches@sourceware.org; Wed, 15 Dec 2010 20:16:51 +0200 (IST) Received: from HOME-C4E4A596F7 ([84.229.167.122]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LDH00MM0ES11M70@a-mtaout21.012.net.il>; Wed, 15 Dec 2010 20:16:51 +0200 (IST) Date: Wed, 15 Dec 2010 18:17:00 -0000 From: Eli Zaretskii Subject: Re: [PATCH] MI disassemble opcode support In-reply-to: <4D08C355.9010809@broadcom.com> To: Andrew Burgess Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83lj3qhpey.fsf@gnu.org> References: <4D08C355.9010809@broadcom.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-12/txt/msg00311.txt.bz2 > Date: Wed, 15 Dec 2010 13:32:05 +0000 > From: "Andrew Burgess" > > Provide an equivalent to "disassemble /r" for the MI interface. The mode parameter to -data-disassemble is extended to control opcode dumping. Thanks. > I've updated the docs in gdb/doc/gdb.texinfo but I didn't know what I was supposed to do to update the gdb/doc/gdb.info-4 file Nothing. gdb.info-* files are produced from gdb.texinfo when GDB is built. > 2010-12-10 Andrew Burgess > > * gdb.texinfo: Update to reflect changes in mi/mi-cmd-disas.c The ChangeLog entry should show the name of the node where this change was made (as if the node were a function). > --- a/gdb/doc/gdb.texinfo > +++ b/gdb/doc/gdb.texinfo > @@ -27567,8 +27567,9 @@ displayed; if @var{lines} is higher than the number of lines between > @var{start-addr} and @var{end-addr}, only the lines up to @var{end-addr} > are displayed. > @item @var{mode} > -is either 0 (meaning only disassembly) or 1 (meaning mixed source and > -disassembly). > +is either 0 (meaning only disassembly), 1 (meaning mixed source and > +disassembly), 2 (meaning disassembly with raw opcodes), or 3 (meaning > +mixed source and disassembly with raw opcodes). > @end table This part is okay. > + MODE: 0 -- disassembly. > + 1 -- disassembly and source. > + 2 -- disassembly and opcodes. > + 3 -- disassembly and source and opcodes. Please edit the last line to be valid English: 3 -- disassembly, source and opcodes. The patch for the manual is okay with these changes.