Re: [patch] GDB 7.2: new feature for "backtrace" that cuts path to file (remain filename)

Tom Tromey
2011-11-02T19:06:27Z

>>>>> "Eldar" == iam ahal <hal9000ed2k@gmail.com> writes:

Eldar> Copyright assignment by [gnu.org #703515] is completed.
Eldar> I've corrected some pieces of the patch by your notes.
Eldar> Also, I've attached the change log.

Thanks.

Eldar> diff -rup gdb-7.3.1-orig/gdb/doc/gdb.texinfo gdb-7.3.1/gdb/doc/gdb.texinfo

I don't recall whether this has had a doc review yet.

I think the patch should also include a NEWS entry.

Eldar> +@item set backtrace filename-display basename
Eldar> +Display only basename of a filename.
Eldar> +
Eldar> +@item set backtrace filename-display basename
Eldar> +Display a filename without the compile directory part.

"basename" is repeated; I think the second one should be
without-compile-directory.

Eldar> + const char *filename_display = get_filename_display_from_sal (&sal);
Eldar> + if (filename_display == NULL)

Blank line between these two lines.

Eldar> 2011-10-30 Eldar Gaynetdinov <hal9000ed2k@gmail.com>
Eldar> Add a new variable that controls a way in which filenames in
Eldar> backtraces is displayed.
Eldar> * gdb.texinfo: Added description of 'filename-display' variable in
Eldar> 'set/show backtrace' section.

doc/ has its own ChangeLog, so this entry must go there.

Otherwise looks good, I think one more revision + doc review and it is
ready.

Tom