From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30307 invoked by alias); 30 Nov 2012 20:22:02 -0000 Received: (qmail 30259 invoked by uid 22791); 30 Nov 2012 20:21:58 -0000 X-SWARE-Spam-Status: No, hits=-4.5 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 30 Nov 2012 20:21:52 +0000 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0MEB00L00HT6EY00@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Fri, 30 Nov 2012 22:21:50 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MEB00LNUHWE4FB0@a-mtaout20.012.net.il>; Fri, 30 Nov 2012 22:21:50 +0200 (IST) Date: Fri, 30 Nov 2012 20:22:00 -0000 From: Eli Zaretskii Subject: Re: [patchv2] GDB 7.2: new feature for "backtrace" that cuts path to file (remain filename) In-reply-to: <20121130185653.GA15394@host2.jankratochvil.net> To: Jan Kratochvil Cc: gdb-patches@sourceware.org, hal9000ed2k@gmail.com Reply-to: Eli Zaretskii Message-id: <83lidiu9im.fsf@gnu.org> References: <20121130185653.GA15394@host2.jankratochvil.net> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00960.txt.bz2 > Date: Fri, 30 Nov 2012 19:56:53 +0100 > From: Jan Kratochvil > Cc: Eldar Gaynetdinov > > starting a new thread, formerly it was: > Re: [patch] GDB 7.2: new feature for "backtrace" that cuts path to file (remain filename) > Message-ID: <20120406142114.GA25129@host2.jankratochvil.net> > http://sourceware.org/ml/gdb-patches/2012-04/msg00106.html Thanks. > +set backtrace filename-display basename|relative|absolute > +show backtrace filename-display > + Control the way in which filenames is displayed in backtraces. > + The default remains unchanged ("relative"). The default cannot "remain" because this setting was not in GDB before. So 'The default is "relative".' is a better wording. > +If backtraces aren't easy to read due to a long absolute filename record and > +you just want to see only a basename or a relative filename, > +you can change this behavior: The current behavior, and the default one after this change, is to show relative file names, so talking about long absolute file names is confusing. I would say something simpler, like You can control how file names are displayed in backtraces. > +@itemx set backtrace filename-display relative > +@cindex backtrace filename-display > +Display a filename without the compilation directory part. "A file name without the directory" can be easily be interpreted as basename. I suggest Display file names relative to the compilation directory. > +@item show backtrace filename-display > +Show the current way to display a filename in backtraces. ^^^^^^^^^^ "filenames", in plural. The documentation parts are OK with these changes. > + add_setshow_enum_cmd ("filename-display", class_obscure, > + filename_display_kind_names, > + &filename_display_string, _("\ > +Set how to display filenames in backtraces."), _("\ > +Show how to display filenames in backtraces."), _("\ > +filename-display can be:\n\ > + basename - display only basename of a filename\n\ > + relative - display a filename without the compilation directory part\n\ Here, too, I'd say "relative to the compilation directory." > + absolute - display an absolute filename\n\ > +By default, as-recorded filename is displayed."), The last sentence seems to imply that the default is different from "relative", and once changed to something else, cannot be restored, since none of the settings is the default. But the truth is that the default is "relative", right?