From: Eli Zaretskii <eliz@gnu.org>
To: Doug Evans <xdje42@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Handle unbuffered Guile memory ports, and zero sized ports
Date: Sun, 29 Mar 2015 15:36:00 -0000 [thread overview]
Message-ID: <83lhifzugv.fsf@gnu.org> (raw)
In-Reply-To: <m31tk8k7x8.fsf@sspiff.org>
> From: Doug Evans <xdje42@gmail.com>
> Date: Sat, 28 Mar 2015 16:40:19 -0700
>
> This patch adds support for unbuffered Guile memory supports,
> and allows for zero sized ports.
>
> Regression tested on amd64-linux.
>
> 2015-03-28 Doug Evans <xdje42@gmail.com>
>
> * NEWS: Mention support for unbuffered Guile memory ports.
> * scm-ports.c (ioscm_memory_port): Update comments on end, size.
> (ioscm_lseek_address): Improve overflow calculation.
> (gdbscm_memory_port_fill_input): Add assert.
> (gdbscm_memory_port_write): Handle unbuffered ports.
> Handle large writes identical to Guile's fport_write.
> (gdbscm_memory_port_seek): Fix seeking past end check.
> (gdbscm_memory_port_close): Handle closing unbuffered port.
> (ioscm_parse_mode_bits): Recognize "0" for unbuffered ports.
> (ioscm_init_memory_port): Handle unbuffered ports.
> (ioscm_reinit_memory_port): Ditto.
> (ioscm_init_memory_port): Update size calculation.
> (gdbscm_open_memory): Support zero sized ports.
>
> testsuite/
> * gdb.guile/scm-ports.c: New file.
> * gdb.guile/scm-ports.exp: Add memory port tests.
>
> doc/
> * guile.texi (Memory Ports in Guile): Document support for unbuffered
> memory ports.
OK for the documentation parts.
Thanks.
next prev parent reply other threads:[~2015-03-29 15:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-28 23:41 Doug Evans
2015-03-29 15:36 ` Eli Zaretskii [this message]
2015-05-16 19:22 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83lhifzugv.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=xdje42@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox