Re: [RFA v3] enable/disable sub breakpoint range

[Eli Zaretskii <eliz@gnu.org>]

> From: Xavier Roirand <roirand@adacore.com>
> Date: Tue, 3 Oct 2017 12:26:49 +0200
> 
> This patch allows enable/disable a range of breakpoint locations
> using syntax:
> 
> <breakpoint_number>.<first_location_number>-<last_location_number>
> 
> with inclusive last_location_number.
> 
> For instance, if adding a breakpoint to foo() generates 5 breakpoint
> locations from 1.1 to 1.5 then it's now possible to enable/disable
> only location breakpoint 1.3 to location breakpoint 1.5
> (so 1.3, 1.4 and 1.5) using syntax:
> 
> enable 1.3-5 or disable 1.3-5

What if I have, in addition to the 1.1-1.5 breakpoints also
breakpoints 4, 5, and 6 -- how do I disable 1.3, 1.4, 1.5, 4, and 5?
Do I have to say something like "disable 1.3-5.0"?

> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -65,6 +65,11 @@ QStartupWithShell
>   * The "maintenance selftest" command now takes an optional argument to
>     filter the tests to be run.
> 
> +* Breakpoint commands accept location ranges.
> +
> +The breakpoint commands ``enable'', and ``disable'' now accept a
> +location range of breakpoints, e.g. ``1.3-5''.
> +

This part is OK.

> +@code{enable} and @code{disable} commands.  It's also possible to
> +@code{enable} and @code{disable} range of @var{location-number}
> +breakpoints using a @var{breakpoint-number} and two @var{location-number},
> +in increasing order, separated by a hyphen, like
> +‘@var{breakpoint-number}.5-7’.
   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
This should be

  @kbd{@var{breakpoint-number}.@var{location-number1}-@var{location-number2}}

or

  @kbd{@var{breakpoint-number}.5-7}

(In general, if you find yourself using `..', "..", or any similar
quoting in a Texinfo source, you can be sure something's wrong ;-)

> +In this case, when a @var{location-number} range is given to this
> +command, all breakpoints belonging to this @var{breakpoint-number}
> +and inside that range are operated on.

It is always best to avoid passive tense, as using that tends to
produce unnecessarily complicated and cumbersome text.  Suggest to
reword:

  If you use such a range of location numbers, @value{GDBN} will act
  on all the breakpoints in that range.

> +Note that you cannot delete the individual locations from the list,
> +you can only delete the entire list of locations that belong to their
> +parent breakpoint (with the @kbd{delete @var{num}} command, where
> +@var{num} is the number of the parent breakpoint, 1 in the above example).
> +Disabling or enabling the parent breakpoint (@pxref{Disabling}) affects
> +all of the locations that belong to that breakpoint.

This is just a complicated way of saying that the 'delete' command
doesn't support location-ranges, right?  If so, why not just say so?

Thanks.