From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20408 invoked by alias); 26 Feb 2018 19:13:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20328 invoked by uid 89); 26 Feb 2018 19:13:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=Hx-languages-length:1394 X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 26 Feb 2018 19:13:31 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eqODH-0004vE-8h for gdb-patches@sourceware.org; Mon, 26 Feb 2018 14:13:30 -0500 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:51138) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eqODH-0004v9-4t; Mon, 26 Feb 2018 14:13:27 -0500 Received: from [176.228.60.248] (port=1529 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eqODG-0001CI-IZ; Mon, 26 Feb 2018 14:13:26 -0500 Date: Mon, 26 Feb 2018 19:13:00 -0000 Message-Id: <83lgff1s4n.fsf@gnu.org> From: Eli Zaretskii To: "Metzger\, Markus T" CC: gdb-patches@sourceware.org In-reply-to: (markus.t.metzger@intel.com) Subject: Re: [PATCH 2/2] btrace: set/show record btrace cpu Reply-to: Eli Zaretskii References: <1519379570-16643-1-git-send-email-markus.t.metzger@intel.com> <1519379570-16643-2-git-send-email-markus.t.metzger@intel.com> <83woz34xuj.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2018-02/txt/msg00394.txt.bz2 > From: "Metzger, Markus T" > CC: "gdb-patches@sourceware.org" > Date: Mon, 26 Feb 2018 15:45:36 +0000 > > > +@item set record btrace cpu @var{identifier} Set the processor to be > > > +used for enabling trace decode errata workarounds. > > > > I think we need to say something about just what those "errata workarounds" > > are, and what are they used for. > > I rephrased this to "... for enabling workarounds for processor errata when > decoding the trace". It's better, but still not clear enough. What kind of "errata" are we talking about? The kind described in https://community.amd.com/thread/186609, for example? And what do the workarounds do? If you can explain that to me or give an example, I will try to propose some text to describe that in the manual. > > > + add_prefix_cmd ("cpu", class_support, cmd_set_record_btrace_cpu, > > > + _("\ > > > +Set the cpu to be used for trace decode.\n\n\ The format is > > > +\": \" or \"none\" or \"auto\" (default). > > ^^ > > So should there be a blank after the colon, or shouldn't there be? > > The example in the manual says no blank. > > White space is ignored. Do we write this explicitly? Not necessarily. But I'd prefer us to consistently use one of the forms. The rest of the patch LGTM, thanks.