From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11610 invoked by alias); 11 Jan 2019 08:04:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11329 invoked by uid 89); 11 Jan 2019 08:04:54 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.2 spammy=emacs, Emacs, mistakes, device X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 11 Jan 2019 08:04:52 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56222) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ghro9-0004BF-3W; Fri, 11 Jan 2019 03:04:49 -0500 Received: from [176.228.60.248] (port=2662 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ghro8-0003VT-Mx; Fri, 11 Jan 2019 03:04:49 -0500 Date: Fri, 11 Jan 2019 08:04:00 -0000 Message-Id: <83lg3rhb6r.fsf@gnu.org> From: Eli Zaretskii To: Simon Marchi CC: gdb-patches@sourceware.org, palves@redhat.com In-reply-to: <20190111001516.4761-1-simon.marchi@ericsson.com> (message from Simon Marchi on Fri, 11 Jan 2019 00:15:34 +0000) Subject: Re: [PATCH] Fix MI output for multi-location breakpoints References: <20190111001516.4761-1-simon.marchi@ericsson.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes X-SW-Source: 2019-01/txt/msg00238.txt.bz2 > From: Simon Marchi > CC: "palves@redhat.com" , Simon Marchi > Date: Fri, 11 Jan 2019 00:15:34 +0000 The documentation changes are approved with these comments: > gdb/doc/ChangeLog: > > * gdb.texinfo (Choosing Modes): Mention mi3. > (Command Interpreters): Likewise. You seem to be using the chapter/section names in the parentheses. You should be using node names instead (or use Emacs, which will do that for you ;-). > diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo > index 4a00834d0bf..a422a395c47 100644 > --- a/gdb/doc/gdb.texinfo > +++ b/gdb/doc/gdb.texinfo > @@ -1268,12 +1268,11 @@ program or device. This option is meant to be set by programs which > communicate with @value{GDBN} using it as a back end. > @xref{Interpreters, , Command Interpreters}. > > -@samp{--interpreter=mi} (or @samp{--interpreter=mi2}) causes > +@samp{--interpreter=mi} (or @samp{--interpreter=mi3}) causes > @value{GDBN} to use the @dfn{@sc{gdb/mi} interface} (@pxref{GDB/MI, , > -The @sc{gdb/mi} Interface}) included since @value{GDBN} version 6.0. The > -previous @sc{gdb/mi} interface, included in @value{GDBN} version 5.3 and > -selected with @samp{--interpreter=mi1}, is deprecated. Earlier > -@sc{gdb/mi} interfaces are no longer supported. > +The @sc{gdb/mi} Interface}). The @sc{gdb/mi} interfaces 1 and 2 are > +available, but deprecated. Earlier @sc{gdb/mi} interfaces are no > +longer available. Please don't remove the version information from this text. At the very least, we should tell what GDB version introduced the latest mi3 syntax. We should tell this here, and not only in the "Interpreters" node, because this section is a concise list of invocation options, and should include the important information without sending the reader to read the more detailed parts. > +@item mi3 > +@cindex mi3 interpreter > +The @sc{gdb/mi} interface introduced in @value{GDBN} 9. It is the latest ^^^^^^^^^^^^^^ GDB 9.1, presumably? > @item mi1 > @cindex mi1 interpreter > -The @sc{gdb/mi} interface included in @value{GDBN} 5.1, 5.2, and 5.3. > +The @sc{gdb/mi} interface introduced in @value{GDBN} 5.1. I think the old text is better. Thanks. P.S. I wonder how did we let this problem slip through the cracks when multiple-location breakpoints were introduced? Maybe we should do something to avoid such mistakes in the future. We really shouldn't be changing the MI syntax in incompatible ways so late into GDB development cycle.