Re: [PATCH v2 3/4] "maint test-settings set/show" -> "maint set/show test-settings"

Eli Zaretskii
2019-06-18T16:35:18Z

> From: Pedro Alves <palves@redhat.com>
> Cc: Philippe Waroquiers <philippe.waroquiers@skynet.be>
> Date: Tue, 18 Jun 2019 01:39:01 +0100
>
> This commit renames "maint test-settings set/show" to "maint set/show
> test-settings".
>
> This helps the following patch, which introduce a "maint with" command
> what works with all "maint set" settings.
>
> gdb/ChangeLog:
> yyyy-mm-dd Pedro Alves <palves@redhat.com>
>
> * NEWS (New commands): Mention "maint set/show test-settings"
> instead of "maint test-settings".
> * maint-test-settings.c (maintenance_test_settings_list): Delete.
> (maintenance_test_settings_set_list): Rename to ...
> (maintenance_set_test_settings_list): ... this.
> (maintenance_test_settings_show_list): Rename to ...
> (maintenance_show_test_settings_list): ... this.
> (maintenance_test_settings_cmd): Delete.
> (maintenance_test_settings_set_cmd): ...
> (maintenance_set_test_settings_cmd): ... this.
> (maintenance_test_settings_show_cmd): ...
> (maintenance_show_test_settings_cmd): ... this.
> (maintenance_test_settings_show_value_cmd):
> (maintenance_show_test_settings_value_cmd): ... this.
> (_initialize_maint_test_settings): No longer install the "maint
> test-settings" prefix command. Rename "maint test-settings set"
> to "maint set test-settings", and "maint test-settings show" to
> "maint show test-settings". Adjust all subcommands.
>
> gdb/doc/ChangeLog:
> yyyy-mm-dd Pedro Alves <palves@redhat.com>
>
> * gdb.texinfo (Maintenance Commands): Document "maint set/show
> test-settings" instead of "maint test-settings set/show".
>
> gdb/testsuite/ChangeLog:
> yyyy-mm-dd Pedro Alves <palves@redhat.com>
>
> * gdb.base/settings.exp: Replace all references to "maint
> test-settings set" with references to "maint set test-settings",
> and all references to "maint test-settings show" with references
> to "maint show test-settings".

OK for the documentation parts.

Thanks.