From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 100234 invoked by alias); 12 Jul 2019 12:48:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 100224 invoked by uid 89); 12 Jul 2019 12:48:52 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-15.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1702, command's X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 12 Jul 2019 12:48:51 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:39544) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hluyn-0001Q6-7a; Fri, 12 Jul 2019 08:48:49 -0400 Received: from [176.228.60.248] (port=1750 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hluym-00065V-CK; Fri, 12 Jul 2019 08:48:49 -0400 Date: Fri, 12 Jul 2019 12:48:00 -0000 Message-Id: <83lfx32zbt.fsf@gnu.org> From: Eli Zaretskii To: Andrew Burgess CC: gdb-patches@sourceware.org In-reply-to: (message from Andrew Burgess on Fri, 12 Jul 2019 12:37:04 +0100) Subject: Re: [PATCH 1/3] gdb: Switch "info types" over to use the gdb::options framework References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes X-SW-Source: 2019-07/txt/msg00346.txt.bz2 > From: Andrew Burgess > Cc: Andrew Burgess > Date: Fri, 12 Jul 2019 12:37:04 +0100 > > Adds a new -q flag to "info types" using the gdb::option framework. > This -q flag is similar to the -q flag already present for "info > variables" and "info functions". Thanks. > diff --git a/gdb/NEWS b/gdb/NEWS > index 4e479bf738b..cc1d58520d4 100644 > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -211,6 +211,10 @@ maint show test-options-completion-result > > (gdb) print -raw -pretty -object off -- *myptr > > + ** The "info types" command now supports the '-q' flag to disable > + printing of some header information in a similar fashion to "info > + variables" and "info functions". > + This part is OK. > +@item info types [-q] [@var{regexp}] > Print a brief description of all types whose names match the regular > expression @var{regexp} (or all types in your program, if you supply > no argument). Each complete typename is matched as though it were a > @@ -18449,6 +18448,9 @@ > @code{whatis}, it does not print a detailed description; second, it > lists all source files and line numbers where a type is defined. > > +The optional flag @samp{-q}, which stands for @samp{quiet}, disables > +printing header information. I don't see "headers" described anywhere in the preceding text, so "disables printing header information" here is not clear enough. Besides, the command's doc string says "some headers and messages", which seems to imply more than just "headers" is suppressed by this switch. Can you please make the effect of this switch more clear? Thanks.