From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24603 invoked by alias); 21 Apr 2009 19:06:56 -0000 Received: (qmail 24581 invoked by uid 22791); 21 Apr 2009 19:06:56 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout5.012.net.il (HELO mtaout5.012.net.il) (84.95.2.13) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 21 Apr 2009 19:06:50 +0000 Received: from conversion-daemon.i_mtaout5.012.net.il by i_mtaout5.012.net.il (HyperSendmail v2004.12) id <0KIG00100SYZDH00@i_mtaout5.012.net.il> for gdb-patches@sourceware.org; Tue, 21 Apr 2009 22:06:32 +0300 (IDT) Received: from HOME-C4E4A596F7 ([84.228.219.161]) by i_mtaout5.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0KIG006Y3T2U4MG0@i_mtaout5.012.net.il>; Tue, 21 Apr 2009 22:06:31 +0300 (IDT) Date: Tue, 21 Apr 2009 19:06:00 -0000 From: Eli Zaretskii Subject: Re: FYI: fix Solaris problem with auto host charset In-reply-to: To: Tom Tromey Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83k55dhlmp.fsf@gnu.org> References: <83y6tyihzh.fsf@gnu.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-04/txt/msg00571.txt.bz2 > Cc: gdb-patches@sourceware.org > From: Tom Tromey > Date: Tue, 21 Apr 2009 12:53:26 -0600 > > >>>>> "Tom" == Tom Tromey writes: > > Eli> Btw, why is the code assuming that nl_langinfo always returns a > Eli> meaningful result? > > Tom> Oversight. > > I re-read the relevant standard text online, and as far as I can tell, > nl_langinfo will only return an empty string if the argument is invalid. > So, I don't think this is an issue for gdb. I thought "invalid argument" includes arguments that are unsupported. Doesn't it?