Re: Static tracepoints support

Pedro Alves
2010-07-01T10:41:33Z

On Wednesday 30 June 2010 19:16:09, Eli Zaretskii wrote:
> > From: Pedro Alves <pedro@codesourcery.com>

> > Here's a new version of the patch integrating all of the
> > above. Any further comments?
>
> Just three:
>
> > + $_sdata internal variable. When analying the trace buffer, you can
> ^^^^^^^^
> A typo (sorry I didn't catch that before).
>
> > +Whether the breakpoint is marked to be disabled or deleted when hit.
>
> Wasn't there supposed to be an @item before this sentence?

Arrh, copy&paste from "info breakpoints".. the sentence wasn't even
supposed to be there, I've removed it (it's describing breakpoint's
dispositions).

>
> > +UST backend, this is the the format string passed as argument to the
> ^^^
> Redundant "the".
>
> Okay with those changes.

Checked in with those changes. Thank you for the review!

--
Pedro Alves