Re: Static tracepoints support

Eli Zaretskii
2010-06-30T18:14:14Z

> From: Pedro Alves <pedro@codesourcery.com>
> Date: Tue, 29 Jun 2010 21:59:48 +0100
>
> Hmm, how about I add a column with a counter, for ease of reading. This
> can't be expected to be stable, but should help readabily --- for example,
> dynamically loaded or unloaded shared libraries can change the number of
> markers in the program. Let me give it a try ... [done].

I think it's a good idea. I just hope users will not think that the
number has the same semantics as with breakpoints. I see you did
mention that in the manual.

> I've spent a while trying to get something that look better,
> and here's the current status:
>
> (gdb) info static-tracepoint-markers
> Cnt ID Enb Address What
> 1 metadata/core_marker_format n 0x00007fc3d7466692
> Data: "channel %s name %s format %s"
> 2 metadata/core_marker_format n 0x00007fc3d7467897
> Data: "channel %s name %s format %s"
> 3 metadata/core_marker_id n 0x00007fc3d746857d
> Data: "channel %s name %s event_id %hu int #1u%zu long #1u%zu pointer #1u%zu size_t #1u%zu alignment #1u%u"
> 4 metadata/core_marker_id n 0x00007fc3d7468a04
> Data: "channel %s name %s event_id %hu int #1u%zu long #1u%zu pointer #1u%zu size_t #1u%zu alignment #1u%u"
> 5 metadata/core_marker_id n 0x00007fc3d746a006
> Data: "channel %s name %s event_id %hu int #1u%zu long #1u%zu pointer #1u%zu size_t #1u%zu alignment #1u%u"
> 6 metadata/core_marker_format n 0x00007fc3d746a235
> Data: "channel %s name %s format %s"
> 7 ust/potential_exec n 0x00007fc3d7487240
> Data: " "
> 8 ust/bar2 y 0x0000000000400c98 in main at stexample.c:40
> Data: "number1 %d number2 %d"
> Probed by static tracepoints: #2
> 9 ust/bar2 n 0x0000000000400df9 in main at stexample.c:41
> Data: "number1 %d number2 %d"
> 10 ust/bar33 n 0x0000000000400fe0 in main at stexample.c:39
> Data: "str %s"
> 11 ust/dummymark n 0x00000000004011a8
> Data: " "

Thanks, I think this is better.

> > But only if the conditionals are different.
> >
> > Anyway, it confused me, so perhaps it's a good idea to clarify.
>
> Okay, I agree, though I'd prefer to do that as a follow up, where I
> change both the break- and tracepoint command's help output at once.
> Is that okay with you?

Yes.

> Here's a new version of the patch integrating all of the
> above. Any further comments?

Just three:

> + $_sdata internal variable. When analying the trace buffer, you can
^^^^^^^^
A typo (sorry I didn't catch that before).

> +Whether the breakpoint is marked to be disabled or deleted when hit.

Wasn't there supposed to be an @item before this sentence?

> +UST backend, this is the the format string passed as argument to the
^^^
Redundant "the".

Okay with those changes.

Thanks.