From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-86900-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 4906 invoked by alias); 10 Jan 2012 17:17:31 -0000
Received: (qmail 4893 invoked by uid 22791); 10 Jan 2012 17:17:30 -0000
X-SWARE-Spam-Status: No, hits=-1.3 required=5.0	tests=AWL,BAYES_00,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 10 Jan 2012 17:17:09 +0000
Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0LXL00L00EADQO00@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Tue, 10 Jan 2012 19:17:07 +0200 (IST)
Received: from HOME-C4E4A596F7 ([77.124.148.90]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LXL00F1GEOILRX0@a-mtaout20.012.net.il>; Tue, 10 Jan 2012 19:17:07 +0200 (IST)
Date: Tue, 10 Jan 2012 17:25:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH] Add bp_location to Python interface
In-reply-to: <CAPftXULwT9pTagJOzVsDjtdFkcoFwTWm3gs0=a=EYzMbZYHPgA@mail.gmail.com>
To: Kevin Pouget <kevin.pouget@gmail.com>
Cc: gdb-patches@sourceware.org, pmuldoon@redhat.com
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83k44zeaui.fsf@gnu.org>
MIME-version: 1.0
Content-type: text/plain; charset=iso-8859-1
Content-transfer-encoding: 8BIT
References: <CAPftXUL7Gag8pOzh6NF2t=nowBgSYa_Je3CkMQHgxexrNz+OHg@mail.gmail.com> <m3liqn9lym.fsf@redhat.com> <CAPftXULeNBNLT=9EixD3sEdtxcLkRuUFY6ny=2k9NSUQqHf+Bg@mail.gmail.com> <m3k4656dkx.fsf@redhat.com> <CAPftXU+NjNead1ZHEc8_P84py3esmOnAKVa2Y1KpxKX_augKsw@mail.gmail.com> <CAPftXUL6KTe-WEFnWR38pVnGUJhmEQgZ0J7R7heeR3GHtmrf5g@mail.gmail.com> <83r4z8eqoa.fsf@gnu.org> <CAPftXULwT9pTagJOzVsDjtdFkcoFwTWm3gs0=a=EYzMbZYHPgA@mail.gmail.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-01/txt/msg00297.txt.bz2

> From: Kevin Pouget <kevin.pouget@gmail.com>
> Date: Tue, 10 Jan 2012 15:50:30 +0100
> Cc: gdb-patches@sourceware.org, pmuldoon@redhat.com
> 
> > In any case, the last 2 sentences sound scary: I could interpret them
> > as meaning I cannot trust the locations at all.  If that is indeed so,
> > what use are they?
> 
> that's already discussed above, but I don't want you to be scared, so
> let me explain what I meant:
> it's not "at any moment", but rather "after any call to GDB's Python
> interface". We may want to say that it's only breakpoint or
> execution-related calls, but _I_ can't ensure that this is true, and
> it 'might' change in the future:
> 
> > A @code{gdb.BpLocation} object may be invalidated during
> > any call to @{GDB}'s API for internal reasons (for instance, but not limited to,
> > breakpoint or execution-related mechanisms).

Sounds okay to me.  But you don't need "but not limited to", because
"for instance" already says that.

> +Return a tuple containing a sequence of @code{gdb.BpLocation} objects 
> +(see below) associated with this breakpoint.  A breakpoint with no location
> +is a pending breakpoint (@xref{Set Breaks, , pending breakpoints}).
                            ^^^^^
Still an @xref...

> +any call to @{GDB}'s API for internal reasons (for instance, but not limited to,
               ^^^^^^
You already know what to fix here...

The documentation parts are OK with those changes.

Thanks.