From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-87541-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 4008 invoked by alias); 27 Jan 2012 09:23:52 -0000
Received: (qmail 3998 invoked by uid 22791); 27 Jan 2012 09:23:51 -0000
X-SWARE-Spam-Status: No, hits=-1.3 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL,TW_SM
X-Spam-Check-By: sourceware.org
Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 27 Jan 2012 09:23:32 +0000
Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0LYG002009S8Q500@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Fri, 27 Jan 2012 11:23:30 +0200 (IST)
Received: from HOME-C4E4A596F7 ([84.228.102.195]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LYG0024TA35KK60@a-mtaout20.012.net.il>; Fri, 27 Jan 2012 11:23:30 +0200 (IST)
Date: Fri, 27 Jan 2012 09:41:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: fix build error on MinGW (HAVE_READLINK) undefined
In-reply-to: <4F2206DE.20907@gmail.com>
To: asmwarrior <asmwarrior@gmail.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83k44dzejs.fsf@gnu.org>
References: <4F2206DE.20907@gmail.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-01/txt/msg00938.txt.bz2

> Date: Fri, 27 Jan 2012 10:07:26 +0800
> From: asmwarrior <asmwarrior@gmail.com>
> 
> diff --git a/gdb/gdbserver/hostio.c b/gdb/gdbserver/hostio.c
> index 34e4fa8..7575fb1 100644
> --- a/gdb/gdbserver/hostio.c
> +++ b/gdb/gdbserver/hostio.c
> @@ -459,6 +459,7 @@ handle_unlink (char *own_buf)
>   static void
>   handle_readlink (char *own_buf, int *new_packet_len)
>   {
> +#if defined (HAVE_READLINK) && defined (PATH_MAX)
>     char filename[PATH_MAX], linkname[PATH_MAX];
>     char *p;
>     int ret, bytes_sent;
> @@ -485,6 +486,10 @@ handle_readlink (char *own_buf, int *new_packet_len)
>        to return a partial response, but simply fail.  */
>     if (bytes_sent < ret)
>       sprintf (own_buf, "F-1,%x", FILEIO_ENAMETOOLONG);
> +#else
> +   hostio_error (own_buf);
> +   return;
> +#endif

I think you need to set errno to EINVAL in the #else branch, because
the meaning of that error on systems that do have readlink is "the
named file is not a symbolic link".

On second thought, perhaps a better way would be to define a readlink
for MinGW that always sets errno to EINVAL and returns -1.  Then the
ugly #ifdef can go away.

> static char *
> inf_child_fileio_readlink (const char *filename, int *target_errno)
> {
>    /* We support readlink only on systems that also provide a compile-time
>       maximum path length (MAXPATHLEN), at least for now.  */
> #if defined (HAVE_READLINK) && defined (MAXPATHLEN)
>    char buf[MAXPATHLEN];
>    int len;
>    char *ret;
> 
>    len = readlink (filename, buf, sizeof buf);

Here too.