From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20327 invoked by alias); 25 Apr 2012 05:47:11 -0000 Received: (qmail 20317 invoked by uid 22791); 25 Apr 2012 05:47:09 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout21.012.net.il (HELO mtaout21.012.net.il) (80.179.55.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 25 Apr 2012 05:46:56 +0000 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0M3000700TC5U800@a-mtaout21.012.net.il> for gdb-patches@sourceware.org; Wed, 25 Apr 2012 08:46:54 +0300 (IDT) Received: from HOME-C4E4A596F7 ([84.229.249.186]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0M300078XTE5LYC0@a-mtaout21.012.net.il>; Wed, 25 Apr 2012 08:46:54 +0300 (IDT) Date: Wed, 25 Apr 2012 06:20:00 -0000 From: Eli Zaretskii Subject: Re: [PATCH] microMIPS support In-reply-to: To: "Maciej W. Rozycki" Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83k414fjmp.fsf@gnu.org> References: X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00842.txt.bz2 > Date: Tue, 24 Apr 2012 21:29:01 +0100 > From: "Maciej W. Rozycki" > > Here's a change that adds support for debugging binaries containing > microMIPS code. There's not much to say about it except that it works. ;) Thanks. > +@item set mips compression @var{arg} > +@kindex set mips compression > +@cindex MIPS code compression Please use lower-case "mips" in the @cindex entry as well. > +Tell @value{GDBN} which MIPS compressed ISA encoding is used by the > +inferior. @value{GDBN} uses this for code disassembly and other > +internal interpretation purposes. This setting is only referred to > +when no executable has been associated with the debugging session or > +the executable does not provide information about the encoding it uses. > +Otherwise this setting is automatically updated from information > +provided by the executable. > + > +Possible values of @var{arg} are @samp{mips16} and @samp{micromips}. > +The default compressed ISA encoding is @samp{mips16}, as executables > +containing MIPS16 code frequently are not identified as such. > + > +This setting is ``sticky''; that is, it retains its value across > +debugging sessions until reset either explicitly with this command or > +implicitly from an executable. > + > +The compiler and/or assembler typically add symbol table annotations to > +identify functions compiled for the MIPS16 or microMIPS ISAs. If these > +function-scope annotations are present, @value{GDBN} uses them in > +preference to the global compressed ISA encoding setting. I would suggest to use either @acronym{ISA} or @sc{isa} (and the same with "MIPS16" and "MIPS"), since they will look better in print. Try both, produce the PDF version of the manual, and keep the one you like best. > +@subsubsection Breakpoint Kinds > + > +These breakpoint kinds are defined for the @samp{Z0} and @samp{Z1} packets. I'd prefer to have a @node here; subsections without a node are possible, but are harder to find. Also, a @cindex entry here would be good; think about someone who'd like to find this information quickly by searching the index. OK with those changes. > + add_setshow_enum_cmd ("compression", class_obscure, mips_compression_strings, > + &mips_compression_string, _("\ > +Set the compressed ISA encoding used."), _("\ > +Show the compressed ISA encoding used."), _("\ I'd mention microMIPS in the doc strings, as in Set the compressed ISA encoding used by microMIPS binaries. > Index: gdb-fsf-trunk-quilt/gdb/NEWS > =================================================================== > --- gdb-fsf-trunk-quilt.orig/gdb/NEWS 2012-04-24 20:57:21.000000000 +0100 > +++ gdb-fsf-trunk-quilt/gdb/NEWS 2012-04-24 20:58:23.645567943 +0100 > @@ -3,6 +3,8 @@ > > *** Changes since GDB 7.4 > > +* GDB now supports debugging microMIPS binaries. > + > * GDB now supports reversible debugging on ARM, it allows you to > debug basic ARM and THUMB instructions, and provides > record/replay support. > @@ -124,6 +126,14 @@ HP OpenVMS ia64 ia64-hp-openvms* > > * New options > > +set mips compression > +show mips compression > + Select the compressed ISA encoding used in functions that have no symbol > + information available. The encoding can be set to either of: > + mips16 > + micromips > + and is updated automatically from ELF file flags if available. > + This is OK.