From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-93040-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 15299 invoked by alias); 24 Jul 2012 17:10:46 -0000
Received: (qmail 15289 invoked by uid 22791); 24 Jul 2012 17:10:44 -0000
X-SWARE-Spam-Status: No, hits=-4.2 required=5.0	tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 24 Jul 2012 17:10:23 +0000
Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0M7O00G00CV5UJ00@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Tue, 24 Jul 2012 20:10:21 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([87.69.210.75]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0M7O00GN6D191UH0@a-mtaout22.012.net.il>; Tue, 24 Jul 2012 20:10:21 +0300 (IDT)
Date: Tue, 24 Jul 2012 17:10:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH 3/6] attach to command_option-changed observer.
In-reply-to: <1343146252-22558-4-git-send-email-yao@codesourcery.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83k3xtkruq.fsf@gnu.org>
References: <1343146252-22558-1-git-send-email-yao@codesourcery.com> <1343146252-22558-4-git-send-email-yao@codesourcery.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-07/txt/msg00496.txt.bz2

> From: Yao Qi <yao@codesourcery.com>
> Date: Wed, 25 Jul 2012 00:10:49 +0800
> 
> This patch is to attach function 'mi_command_option_changed' to
> observer 'command_option_changed', so that a MI notification
> "=option-changed" is sent to MI frontend.  If the command option
> change is requested from MI, the notification is suppressed.

Thanks.

> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -3,6 +3,11 @@
>  
>  *** Changes since GDB 7.5
>  
> +* MI changes
> +
> +  ** Command option changes are now notified using new async record
> +     "=option-changed".

OK.

> +@item =option-changed,option=@var{command},value=@var{value}
> +Reports that an option of the command @var{set command} is changed
> +to @var{value}.                       ^^^^^^^^^^^^^^^^^

Please use "@code{set @var{command}}" instead of the underlined part.
Only COMMAND should be in @var, since "set" is a literal string.

Btw, it is better to use "option" instead of "command" in the above,
since that's what "set" does -- it changes values of user options.

The documentation parts are OK with those changes.