From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-93261-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 16701 invoked by alias); 28 Jul 2012 07:28:21 -0000
Received: (qmail 16689 invoked by uid 22791); 28 Jul 2012 07:28:18 -0000
X-SWARE-Spam-Status: No, hits=-4.2 required=5.0	tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout21.012.net.il (HELO mtaout21.012.net.il) (80.179.55.169)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 28 Jul 2012 07:27:59 +0000
Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0M7V00K000O71400@a-mtaout21.012.net.il> for gdb-patches@sourceware.org; Sat, 28 Jul 2012 10:27:57 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([87.69.210.75]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0M7V00JJ20QHSWA0@a-mtaout21.012.net.il>; Sat, 28 Jul 2012 10:27:54 +0300 (IDT)
Date: Sat, 28 Jul 2012 07:28:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [patchv2] Write bpt at the ON_STACK bpt address
In-reply-to: <20120727184633.GA14182@host2.jankratochvil.net>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: philippe.waroquiers@skynet.be, palves@redhat.com, brobecker@adacore.com, gdb-patches@sourceware.org, macro@codesourcery.com
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83k3xoibul.fsf@gnu.org>
References: <20120727184633.GA14182@host2.jankratochvil.net>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-07/txt/msg00717.txt.bz2

> Date: Fri, 27 Jul 2012 20:46:33 +0200
> From: Jan Kratochvil <jan.kratochvil@redhat.com>
> Cc: Joel Brobecker <brobecker@adacore.com>, gdb-patches@sourceware.org,        "Maciej W. Rozycki" <macro@codesourcery.com>
> 
> -breakpoint should be inserted.  May return @code{NULL} to indicate that
> -software breakpoints are not supported.
> +breakpoint should be inserted.  The program counter (@code{*@var{pcptr}}
> +is inferior PC register encoded on the input and it is a plain address on the
> +output.  Function may return @code{NULL} to indicate that software breakpoints
> +are not supported.

I suggest a slight rewording:

 On input, the program counter (@code{*@var{pcptr}} is the encoded
 inferior's PC register.  The function returns the PC's plain address
 in this argument, or @code{NULL} if software breakpoints are not
 supported.

Does this catch the intent correctly?

> -the return address (@var{bp_addr}).
> +the return address (@var{bp_addr}, in inferior PC register encoding).
                                         ^^^^^^^^
"inferior's"

> -should be inserted, @var{real_pc} to the resume address when starting
> -the call sequence, and return the updated inner-most stack address.
> +should be inserted (in inferior PC register encoding), @var{real_pc} to the
                          ^^^^^^^^
Likewise.

> -reserved for that breakpoint, and @var{real_pc} set to @var{funaddr}.
> +reserved for that breakpoint (in inferior PC register encoding), and
                                    ^^^^^^^^
Likewise.

OK with these changes.

Thanks.