From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1697 invoked by alias); 27 Mar 2013 11:23:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1221 invoked by uid 89); 27 Mar 2013 11:23:09 -0000 X-Spam-SWARE-Status: No, score=-4.4 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,RCVD_IN_HOSTKARMA_YE,SPF_SOFTFAIL autolearn=no version=3.3.1 Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 27 Mar 2013 11:23:06 +0000 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MKB00000GXJWE00@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Wed, 27 Mar 2013 13:22:32 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MKB000W5GXJW300@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Wed, 27 Mar 2013 13:22:32 +0200 (IST) Date: Wed, 27 Mar 2013 16:06:00 -0000 From: Eli Zaretskii Subject: Re: [RFA] Fix cygwin32 failure introduced by [patch] windows-nat.c: Fix offset problem in signal string handling In-reply-to: <20130327111301.GA28863@calimero.vinschen.de> To: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83k3otxf20.fsf@gnu.org> References: <20130319151436.GB20727@calimero.vinschen.de> <20130319212554.GE4506@adacore.com> <000101ce2a6b$8c855a60$a5900f20$%muller@ics-cnrs.unistra.fr> <83y5d9xrqt.fsf@gnu.org> <005501ce2ac8$ae830150$0b8903f0$%muller@ics-cnrs.unistra.fr> <83obe5xgq2.fsf@gnu.org> <20130327111301.GA28863@calimero.vinschen.de> X-SW-Source: 2013-03/txt/msg01016.txt.bz2 > Date: Wed, 27 Mar 2013 12:13:01 +0100 > From: Corinna Vinschen > > > > ../../src/gdb/windows-nat.c: In function 'handle_output_debug_string': > > > ../../src/gdb/windows-nat.c:993:16: erreur: assignment makes pointer from integer without a cast > > > > Right. But IMO the casts here are dubious to begin with. strtoull > > produces a 64-bit value; casting it to a 32-bit uintptr_t might shut > > This is really no problem. We know what value comes out of Cygwin. > It's a 32 bit pointer value on 32 bit and a 64 bit value on 64 bit, > so the cast is always right. It may be right, but clean it isn't. I guess we will have to disagree. > Please stop CCing me. It's not me, it's the "reply" function of my mailer. If you don't want to get a copy, please set up your mail headers to cause that.