From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-105742-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 27939 invoked by alias); 25 Sep 2013 05:57:52 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 27926 invoked by uid 89); 25 Sep 2013 05:57:51 -0000
Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 25 Sep 2013 05:57:51 +0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-4.0 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.3.2
X-HELO: mtaout22.012.net.il
Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MTO00B0030EAR00@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Wed, 25 Sep 2013 08:57:48 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MTO00BCW38CAZ10@a-mtaout22.012.net.il>; Wed, 25 Sep 2013 08:57:48 +0300 (IDT)
Date: Wed, 25 Sep 2013 05:57:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [RFA, doc RFA] Add "set debug symfile on".
In-reply-to: <yjt261tpbvdj.fsf@ruffy.mtv.corp.google.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83k3i5h28j.fsf@gnu.org>
References: <yjt261tpbvdj.fsf@ruffy.mtv.corp.google.com>
X-IsSubscribed: yes
X-SW-Source: 2013-09/txt/msg00887.txt.bz2

> From: Doug Evans <dje@google.com>
> Date: Tue, 24 Sep 2013 17:25:12 -0700
> 
> Hi.
> 
> This patch adds a new debugging option: set debug symfile on
> 
> For now it logs all calls through the symfile functions.
> 
> Regression tested on amd64-linux.
> 
> Ok to check in?

Thanks.

> --- NEWS	16 Sep 2013 17:47:29 -0000	1.614
> +++ NEWS	25 Sep 2013 00:03:11 -0000
> @@ -46,6 +46,10 @@ maint set|show per-command symtab
>  
>  * New options
>  
> +set debug symfile off|on
> +show debug symfile
> +  Control display of debugging info for symfile functions.

I'm not sure everybody knows what a "symfile" is.  How about this
instead:

  Control display of debugging info regarding reading symbol files and
  symbol tables within those files.

> --- doc/gdb.texinfo	16 Sep 2013 18:00:34 -0000	1.1112
> +++ doc/gdb.texinfo	25 Sep 2013 00:03:12 -0000
> @@ -22573,6 +22573,12 @@ Turns on or off debugging messages for F
>  @item show debug solib-frv
>  Display the current state of FR-V shared-library code debugging
>  messages.
> +@item set debug symfile
> +@cindex symbol file functions
> +Turns on or off display of debugging messages related to symbol file functions.

This could use a cross-reference to where symbol files are described
(the "Files" node).

> +The default is off.
> +@item show debug symfile
> +Show the current state of symbol file debugging.

  "Show the current state of symbol file debugging messages."

OK with those changes.