From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-105802-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 4533 invoked by alias); 27 Sep 2013 05:52:42 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 4518 invoked by uid 89); 27 Sep 2013 05:52:41 -0000
Received: from mtaout21.012.net.il (HELO mtaout21.012.net.il) (80.179.55.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 27 Sep 2013 05:52:41 +0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-0.3 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_20,SPAM_SUBJECT autolearn=no version=3.3.2
X-HELO: mtaout21.012.net.il
Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0MTR00A00S33T100@a-mtaout21.012.net.il> for gdb-patches@sourceware.org; Fri, 27 Sep 2013 08:52:38 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MTR00ALOSBQJL30@a-mtaout21.012.net.il>; Fri, 27 Sep 2013 08:52:38 +0300 (IDT)
Date: Fri, 27 Sep 2013 05:52:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [RFC 3/6] mingw-hdep: Add "maint set testuite-mode on/off" command.
In-reply-to: <"003e01cebaf4$e97923e0$bc6b6ba0$@muller"@ics-cnrs.unistra.fr>
To: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83k3i2g6aq.fsf@gnu.org>
References: <"002901cebaf2$35ec65a0$a1c530e0$@muller"@ics-cnrs.unistra.fr> <"003201cebaf3$338a8b60$9a9fa220$@muller"@ics-cnrs.unistra.fr> <83li2jfis1.fsf@gnu.org> <"003e01cebaf4$e97923e0$bc6b6ba0$@muller"@ics-cnrs.unistra.fr>
X-IsSubscribed: yes
X-SW-Source: 2013-09/txt/msg00947.txt.bz2

> From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
> Cc: <gdb-patches@sourceware.org>
> Date: Thu, 26 Sep 2013 22:13:47 +0200
> 
> > Shouldn't this command be supported on all platforms, and be a no-op
> > on all of them but MinGW?  Otherwise the test suite will fail for
> > tests that use this setting, won't it?
> 
>   Yes, this is indeed a possibility, 
> but I think that I suggested this already some time ago,
> and that the feedback was not very positive...
> 
>   Anyhow, take a look at part 4 of the patch series,
> which adds "-iex {maint set testsuite-mode on}" to GDBINTERNALFLAGS
> if, and only if, the host is *-*-mingw*.
>   This should avoid the problem you raise, no?

Yes, but it puts the burden of remembering that on the person who
writes the test, which IMO is sub-optimal.